[12.x] dark mode support for mail #57989
Open
+85
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
MrPunyapal
force-pushed
the
feat/dark-mode-support-for-mail
branch
from
0483c89 to
331b242
Compare
MrPunyapal
force-pushed
the
feat/dark-mode-support-for-mail
branch
from
331b242 to
400fa75
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick note: we can't rely on
default.cssalone for dark-mode because the Markdown renderer sends the theme throughCssToInlineStyleswhich inlines normal rules intostyle=""attributes — media queries like@media (prefers-color-scheme: dark)cannot be inlined and therefore must be present as stylesheet rules in the final<head>to work. For this PR I placed the@mediablock inlayout.blade.phpso it ends up in the email head and can override the inlined light-mode styles (using !important).Alternative (preferred long-term): keep the single
default.cssas source-of-truth and modifyIlluminate\Mail\Markdownto extract@mediablocks and expose them (e.g.Markdown::getHead()), then emit that in the layout head — this preserves one CSS file while ensuring media queries reach the final HTML.