[12.x] Add error message to Resume, Restart & Pause commands when disabling worker cache #57991
+24
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for pause,restart and resume commands
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jackbayliss
changed the title
jackbayliss
commented
Dec 1, 2025
| if (! Worker::$pausable) { | ||
| $this->components->error('Worker::$pausable must be set to true to use this command.'); | ||
|
|
||
| return 1; |
Contributor
Author
There was a problem hiding this comment.
I've left this as 1 - as its returning 0 down below. I'll probably do another PR to normalize them all to use self::SUCCESS / FAILURE if this is merged 🤷🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Off the back of #57975 - I thought it would be useful to add these error messages (which came to mind by the Exception suggestion by @cosmastech 🙏🏻 )
I've used messages as feels more command like than an exception.
This just means the commands can't run - cache keys aren't set etc if we know they're not going to be used as we've explicitly turned them off in the Worker
I've also added a return type to the restart command, so it's clear and follows elsewhere (such as the cache clear command)
Any suggestions let me know!
Cheers.