Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: levpickis/feast
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: levpickis/feast
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.19-branch
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 16 commits
  • 46 files changed
  • 7 contributors

Commits on Mar 5, 2022

  1. fix: Fix unhashable Snowflake and Redshift sources 

    Signed-off-by: Willem Pienaar <[email protected]>
    @woop
    woop committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    6f8a3b0 View commit details
    Browse the repository at this point in the history

  2. chore(release): release 0.19.1 

    ## [0.19.1](feast-dev/feast@v0.19.0...v0.19.1) (2022-03-05)

### Bug Fixes

* Fix unhashable Snowflake and Redshift sources ([6f8a3b0](feast-dev@6f8a3b0))
    @feast-ci-bot
    feast-ci-bot committed Mar 5, 2022
    Configuration menu
    Copy the full SHA
    66ce6df View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2022

  1. fix: Fix default feast apply path without any extras (feast-dev#2373) 

    * fix: Fix default feast apply path without any extras

Signed-off-by: Danny Chiao <[email protected]>

* revert removing ge

Signed-off-by: Danny Chiao <[email protected]>
    @adchia
    adchia committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    73e4dde View commit details
    Browse the repository at this point in the history

  2. chore(release): release 0.19.2 

    ## [0.19.2](feast-dev/feast@v0.19.1...v0.19.2) (2022-03-06)

### Bug Fixes

* Fix default feast apply path without any extras ([feast-dev#2373](feast-dev#2373)) ([73e4dde](feast-dev@73e4dde))
    @feast-ci-bot
    feast-ci-bot committed Mar 6, 2022
    Configuration menu
    Copy the full SHA
    7eb430a View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2022

  1. fix: Fix spark docs (feast-dev#2382) 

    * Fix spark docs

Signed-off-by: Kevin Zhang <[email protected]>

* Fix readme.md

Signed-off-by: Kevin Zhang <[email protected]>

* Fix md

Signed-off-by: Kevin Zhang <[email protected]>

Co-authored-by: Danny Chiao <[email protected]>
(cherry picked from commit d4a606a)
    @kevjumba @adchia
    kevjumba and adchia committed Mar 8, 2022
    Configuration menu
    Copy the full SHA
    599dbbb View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. fix: Use the correct dockerhub image tag when building feature servers ( 

    feast-dev#2372)

* fix: Use the correct dockerhub image tag when building feature servers

Signed-off-by: Achal Shah <[email protected]>

* Print attempt

Signed-off-by: Achal Shah <[email protected]>

* Increase sleep interval

Signed-off-by: Achal Shah <[email protected]>

* More logging and sleep

Signed-off-by: Achal Shah <[email protected]>

* change logging to debug

Signed-off-by: Achal Shah <[email protected]>

* Change the dockerimage name

Signed-off-by: Achal Shah <[email protected]>

* Change version to have periods

Signed-off-by: Achal Shah <[email protected]>

* Change version entirely

Signed-off-by: Achal Shah <[email protected]>

* Undo unintended changes

Signed-off-by: Achal Shah <[email protected]>

* Remove dead branch

Signed-off-by: Achal Shah <[email protected]>
    @achals @adchia
    achals authored and adchia committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    a6211cf View commit details
    Browse the repository at this point in the history

  2. fix: Making a name for data sources not a breaking change (feast-dev#… 

    …2379)

* fix: Making a name for data sources not a breaking change

Signed-off-by: Danny Chiao <[email protected]>

* fix test

Signed-off-by: Danny Chiao <[email protected]>
    @adchia
    adchia committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    993b8cc View commit details
    Browse the repository at this point in the history

  3. fix: Closes threadpool resources upon datastore online_write_batch co… 

    …mpletion (feast-dev#2386)

Signed-off-by: Pamela Toman <[email protected]>
    @ptoman-pa @adchia
    ptoman-pa authored and adchia committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    7a93152 View commit details
    Browse the repository at this point in the history

  4. fix: Fixing Spark template to include source name (feast-dev#2381) 

    Signed-off-by: Danny Chiao <[email protected]>
    @adchia
    adchia committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    e7a3b3f View commit details
    Browse the repository at this point in the history

  5. fix: Fix Spark template to work correctly on feast init -t spark (fea… 

    …st-dev#2393)

Signed-off-by: Danny Chiao <[email protected]>
    @adchia
    adchia committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    d877d27 View commit details
    Browse the repository at this point in the history

  6. chore(release): release 0.19.3 

    ## [0.19.3](feast-dev/feast@v0.19.2...v0.19.3) (2022-03-09)

### Bug Fixes

* Closes threadpool resources upon datastore online_write_batch completion ([feast-dev#2386](feast-dev#2386)) ([7a93152](feast-dev@7a93152))
* Fix spark docs ([feast-dev#2382](feast-dev#2382)) ([599dbbb](feast-dev@599dbbb))
* Fix Spark template to work correctly on feast init -t spark ([feast-dev#2393](feast-dev#2393)) ([d877d27](feast-dev@d877d27))
* Fixing Spark template to include source name ([feast-dev#2381](feast-dev#2381)) ([e7a3b3f](feast-dev@e7a3b3f))
* Making a name for data sources not a breaking change ([feast-dev#2379](feast-dev#2379)) ([993b8cc](feast-dev@993b8cc))
* Use the correct dockerhub image tag when building feature servers ([feast-dev#2372](feast-dev#2372)) ([a6211cf](feast-dev@a6211cf))
    @feast-ci-bot
    feast-ci-bot committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    0384bb9 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. ci: Pin setup-gcloud actions to v0 instead of master (feast-dev#2434) 

    Signed-off-by: Felix Wang <[email protected]>
    @felixwang9817
    felixwang9817 committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    1b7c0fc View commit details
    Browse the repository at this point in the history

  2. fix: Don't prevent apply from running given duplicate empty names in … 

    …data sources. Also fix repeated apply of Spark data source. (feast-dev#2415)

* fix: Print more warning statements on requirement for data sources to have name in future, but don't prevent apply from running if there are duplicate empty data sources. Also attach class type when applying data sources so repeated feast apply commands properly work for Spark

Signed-off-by: Danny Chiao <[email protected]>

* typo

Signed-off-by: Danny Chiao <[email protected]>

* typo

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* More tests

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* revert

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>

* fix

Signed-off-by: Danny Chiao <[email protected]>
    @adchia @felixwang9817
    adchia authored and felixwang9817 committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    88e01a2 View commit details
    Browse the repository at this point in the history

  3. fix: Add spark to lambda dockerfile (feast-dev#2480) 

    * add spark to lambda dockerfile

Signed-off-by: Achal Shah <[email protected]>

* add *args

Signed-off-by: Achal Shah <[email protected]>

* Add *args

Signed-off-by: Felix Wang <[email protected]>

* Pin protobuf==3.19.4

Signed-off-by: Felix Wang <[email protected]>

* Remove *args

Signed-off-by: Felix Wang <[email protected]>

* Add a range

Signed-off-by: Achal Shah <[email protected]>

* Add a todo

Signed-off-by: Achal Shah <[email protected]>

* cleanup prints

Signed-off-by: Achal Shah <[email protected]>

* lock deps

Signed-off-by: Achal Shah <[email protected]>

* lock deps correctly

Signed-off-by: Achal Shah <[email protected]>

* fix lint

Signed-off-by: Achal Shah <[email protected]>

* fix lint take 2

Signed-off-by: Achal Shah <[email protected]>

* Undo general updates

Signed-off-by: Achal Shah <[email protected]>

Co-authored-by: Felix Wang <[email protected]>
    @achals @felixwang9817
    achals and felixwang9817 committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    ba22c28 View commit details
    Browse the repository at this point in the history

  4. fix: Fix DataSource constructor to unbreak custom data sources (feast… 

    …-dev#2492)

* fix: Fix DataSource constructor to unbreak custom data sources

Signed-off-by: Achal Shah <[email protected]>

* fix first party refernces to use kwargs only

Signed-off-by: Achal Shah <[email protected]>

* remove force kwargs

Signed-off-by: Achal Shah <[email protected]>
    @achals @felixwang9817
    achals authored and felixwang9817 committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    2115bd0 View commit details
    Browse the repository at this point in the history

  5. chore(release): release 0.19.4 

    ## [0.19.4](feast-dev/feast@v0.19.3...v0.19.4) (2022-04-06)

### Bug Fixes

* Add spark to lambda dockerfile ([feast-dev#2480](feast-dev#2480)) ([ba22c28](feast-dev@ba22c28))
* Don't prevent apply from running given duplicate empty names in data sources. Also fix repeated apply of Spark data source. ([feast-dev#2415](feast-dev#2415)) ([88e01a2](feast-dev@88e01a2))
* Fix DataSource constructor to unbreak custom data sources ([feast-dev#2492](feast-dev#2492)) ([2115bd0](feast-dev@2115bd0))
    @feast-ci-bot
    feast-ci-bot committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    20e7a6f View commit details
    Browse the repository at this point in the history
Loading