Revert "Bug #27584165 TUPLE CORRUPTION DETECTED AND DATA NODE CRASH IN DBTUPEXECQUERY.CPP"

This reverts commit 7d01d8d94784da07d8bec2ab072f8f39aba21f6d.

Reverting due to the following autotest failures:

> testNodeRestart -l 1 -n MixedPkReadPkUpdate
> testNodeRestart -l 1 -n MixedReadUpdateScan

(cherry picked from commit fd05b58532934c6be53d8123bfd506793c9cc6e8)

Author: dssanju

storage/ndb/src/kernel/blocks/dbtup/Dbtup.hpp

@@ -1416,15 +1416,6 @@ typedef Ptr<HostBuffer> HostBufferPtr;
      data. In the case of abort, the varpart must then be shrunk. For a
      MM_GROWN tuple, the original size is stored in the last word of the
      varpart until commit.
-
-     DELETE_WAIT: When a tuple has been marked to be deleted, the tuple header
-     has the DELETE_WAIT bit set. Note that DELETE_WAIT means that the tuple
-     hasn't actually been deleted. When a tuple has been deleted, it is marked
-     with the FREE flag and DELETE_WAIT is reset.
-     The need for DELETE_WAIT arises due to the real-time break between the
-     marking of the tuple and the actual deletion of the tuple for disk data
-     rows. This information would be useful for reads since they'd know the
-     proper state of the row. (Related Bug #27584165)
     */
     STATIC_CONST( TUP_VERSION_MASK = 0xFFFF );
     STATIC_CONST( COPY_TUPLE  = 0x00010000 ); // Is this a copy tuple
@@ -1439,7 +1430,6 @@ typedef Ptr<HostBuffer> HostBufferPtr;
     STATIC_CONST( LCP_SKIP    = 0x01000000 ); // Should not be returned in LCP
     STATIC_CONST( VAR_PART    = 0x04000000 ); // Is there a varpart
     STATIC_CONST( REORG_MOVE  = 0x08000000 );
-    STATIC_CONST( DELETE_WAIT = 0x20000000 ); // Waiting for delete tuple page
 
     Tuple_header() {}
     Uint32 get_tuple_version() const { 

storage/ndb/src/kernel/blocks/dbtup/DbtupCommit.cpp

@@ -895,8 +895,6 @@ void Dbtup::execTUP_COMMITREQ(Signal* signal)
                            regOperPtr,
                            diskPagePtr) == 0)
     {
-      // set bit
-      tuple_ptr->m_header_bits = tuple_ptr->m_header_bits | Tuple_header::DELETE_WAIT;
       return; // Data page has not been retrieved yet.
     }
     get_page = true;
@@ -966,9 +964,6 @@ void Dbtup::execTUP_COMMITREQ(Signal* signal)
                     regFragPtr.p,
                     regTabPtr.p,
                     diskPagePtr);
-
-      //reset bit
-      tuple_ptr->m_header_bits = tuple_ptr->m_header_bits & (~Tuple_header::DELETE_WAIT);
     }
     else if(regOperPtr.p->op_type != ZREFRESH)
     {

storage/ndb/src/kernel/blocks/dbtup/DbtupScan.cpp

@@ -1118,8 +1118,7 @@ Dbtup::scanNext(Signal* signal, ScanOpPtr scanPtr)
 	  {
 	    jam();
             thbits = th->m_header_bits;
-      if (! ((thbits & Tuple_header::FREE) ||
-             (thbits & Tuple_header::DELETE_WAIT)))
+	    if (! (thbits & Tuple_header::FREE))
 	    {
               goto found_tuple;
 	    } 
@@ -1136,8 +1135,7 @@ Dbtup::scanNext(Signal* signal, ScanOpPtr scanPtr)
 	    if ((foundGCI = *th->get_mm_gci(tablePtr.p)) > scanGCI ||
                 foundGCI == 0)
 	    {
-	      if (! ((thbits & Tuple_header::FREE) ||
-	             (thbits & Tuple_header::DELETE_WAIT)))
+	      if (! (thbits & Tuple_header::FREE))
 	      {
 		jam();
 		goto found_tuple;
@@ -1231,8 +1229,7 @@ Dbtup::scanNext(Signal* signal, ScanOpPtr scanPtr)
 	  if ((foundGCI = *th->get_mm_gci(tablePtr.p)) > scanGCI ||
               foundGCI == 0)
 	  {
-      if (! ((thbits & Tuple_header::FREE) ||
-             (thbits & Tuple_header::DELETE_WAIT)))
+	    if (! (thbits & Tuple_header::FREE))
 	      break;
 	  }
 	}