Skip to content

Commit d2bd9d9

Browse files
authored
Merge pull request karmada-io#2092 from carlory/karmadactl-exec
use kubectl exec to implement karmadactl exec and introduce the `--namespace` flag
2 parents 778b2ea + a31315c commit d2bd9d9

File tree

11 files changed

+1251
-302
lines changed

11 files changed

+1251
-302
lines changed

go.mod

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ require (
88
github.com/gogo/protobuf v1.3.2
99
github.com/google/uuid v1.1.2
1010
github.com/kr/pretty v0.3.0
11-
github.com/moby/term v0.0.0-20210619224110-3f7ff695adc6
1211
github.com/olekukonko/tablewriter v0.0.4
1312
github.com/onsi/ginkgo/v2 v2.1.3
1413
github.com/onsi/gomega v1.18.1
@@ -102,6 +101,7 @@ require (
102101
github.com/mitchellh/go-wordwrap v1.0.0 // indirect
103102
github.com/mitchellh/mapstructure v1.4.3 // indirect
104103
github.com/moby/spdystream v0.2.0 // indirect
104+
github.com/moby/term v0.0.0-20210619224110-3f7ff695adc6 // indirect
105105
github.com/modern-go/concurrent v0.0.0-20180306012644-bacd9c7ef1dd // indirect
106106
github.com/modern-go/reflect2 v1.0.2 // indirect
107107
github.com/monochromegane/go-gitignore v0.0.0-20200626010858-205db1a8cc00 // indirect

pkg/karmadactl/describe.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ func (o *CommandDescribeOptions) Complete(karmadaConfig KarmadaConfig, args []st
125125
return err
126126
}
127127

128-
f := getFactory(o.Cluster, clusterInfo)
128+
f := getFactory(o.Cluster, clusterInfo, "")
129129

130130
o.Namespace, o.EnforceNamespace, err = f.ToRawKubeConfigLoader().Namespace()
131131
if err != nil {

0 commit comments

Comments
 (0)