Release the GIL if necessary before calling Replace in main thread

Needed if (re)replace called in N++ callback

Author: bruderstein

PythonScript/python_tests/tests/ScintillaCallbackTestCase.py

@@ -208,6 +208,19 @@ def callback_sync_disallowed_notepad_method(self, args):
         with self.assertRaisesRegexp(RuntimeError, "not allowed in a synchronous"):
             scintilla = notepad.createScintilla()
 
+    def test_callback_with_replace(self):
+        editor.callback(lambda a: self.callback_with_replace(a), [SCINTILLANOTIFICATION.MODIFIED])
+        editor.write('hello world')
+        self.poll_for_callback()
+        text = editor.getText()
+        self.assertEqual(text, 'hello CHEESE')
+
+    def callback_with_replace(self, args):
+        if args['modificationType'] & MODIFICATIONFLAGS.INSERTTEXT:
+            editor.rereplace('wo[a-z]{3}', 'CHEESE')
+            self.callbackCalled = True
+
+
     def poll_for_callback(self, timeout = 0.5, interval = 0.1):
         while self.callbackCalled == False and timeout > 0:
             time.sleep(interval)

PythonScript/src/ScintillaWrapper.cpp

@@ -864,6 +864,7 @@ void ScintillaWrapper::replaceImpl(boost::python::object searchStr, boost::pytho
 	TCHAR pluginName[] = _T("PythonScript.dll");
 
     commInfo.info = reinterpret_cast<void*>(&replacementContainer);
+    GILRelease release;
 	::SendMessage(m_hNotepad, NPPM_MSGTOPLUGIN, reinterpret_cast<WPARAM>(pluginName), reinterpret_cast<LPARAM>(&commInfo));
 
     EndUndoAction();