Should delete a transaction from the mempool if it is in a block

Author: micahriggan

packages/bitcore-node/test/verification/db-verify.ts

@@ -23,10 +23,22 @@ export async function validateDataForBlock(blockNum: number, log = false) {
   const blockTxs = await TransactionStorage.collection.find({ chain, network, blockHeight: blockNum }).toArray();
   const blockTxids = blockTxs.map(t => t.txid);
   const coinsForTx = await CoinStorage.collection.find({ chain, network, mintTxid: { $in: blockTxids } }).toArray();
+  const mempoolTxs = await TransactionStorage.collection
+    .find({ chain, network, blockHeight: -1, txid: { $in: blockTxids } })
+    .toArray();
 
   const seenTxs = {} as { [txid: string]: ITransaction };
   const errors = new Array<ErrorType>();
 
+  for (const tx of mempoolTxs) {
+    success = false;
+    const error = { model: 'transaction', err: true, type: 'DUPE_TRANSACTION', payload: { tx, blockNum } };
+    errors.push(error);
+    if (log) {
+      console.log(JSON.stringify(error));
+    }
+  }
+
   const seenTxCoins = {} as { [txid: string]: ICoin[] };
   for (let tx of blockTxs) {
     if (tx.fee < 0) {