Skip to content

Commit 9a204fc

Browse files
committed
MAPREDUCE-2876. Use a different config for ContainerAllocationExpirer. Contributed by Anupam Seth.
git-svn-id: https://svn.apache.org/repos/asf/hadoop/common/trunk@1180767 13f79535-47bb-0310-9956-ffa450edef68
1 parent 3a2fc65 commit 9a204fc

File tree

5 files changed

+20
-29
lines changed

5 files changed

+20
-29
lines changed

hadoop-mapreduce-project/CHANGES.txt

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1546,6 +1546,9 @@ Release 0.23.0 - Unreleased
15461546
MAPREDUCE-2802. Ensure JobHistory filenames have jobId. (Jonathan Eagles
15471547
via acmurthy)
15481548

1549+
MAPREDUCE-2876. Use a different config for ContainerAllocationExpirer.
1550+
(Anupam Seth via acmurthy)
1551+
15491552
Release 0.22.0 - Unreleased
15501553

15511554
INCOMPATIBLE CHANGES

hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-common/src/main/java/org/apache/hadoop/yarn/conf/YarnConfiguration.java

Lines changed: 4 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -146,22 +146,11 @@ public class YarnConfiguration extends Configuration {
146146
RM_PREFIX + "admin.client.thread-count";
147147
public static final int DEFAULT_RM_ADMIN_CLIENT_THREAD_COUNT = 1;
148148

149-
/** How often should the RM check that the AM is still alive.*/
150-
public static final String RM_AM_LIVENESS_MONITOR_INTERVAL_MS =
151-
RM_PREFIX + "amliveliness-monitor.interval-ms";
152-
public static final int DEFAULT_RM_AM_LIVENESS_MONITOR_INTERVAL_MS = 1000;
153-
154149
/** The maximum number of application master retries.*/
155150
public static final String RM_AM_MAX_RETRIES =
156151
RM_PREFIX + "am.max-retries";
157152
public static final int DEFAULT_RM_AM_MAX_RETRIES = 1;
158153

159-
/** How often to check that containers are still alive. */
160-
public static final String RM_CONTAINER_LIVENESS_MONITOR_INTERVAL_MS =
161-
RM_PREFIX + "container.liveness-monitor.interval-ms";
162-
public static final int DEFAULT_RM_CONTAINER_LIVENESS_MONITOR_INTERVAL_MS =
163-
600000;
164-
165154
/** The keytab for the resource manager.*/
166155
public static final String RM_KEYTAB =
167156
RM_PREFIX + "keytab";
@@ -171,10 +160,10 @@ public class YarnConfiguration extends Configuration {
171160
RM_PREFIX + "nm.liveness-monitor.expiry-interval-ms";
172161
public static final int DEFAULT_RM_NM_EXPIRY_INTERVAL_MS = 600000;
173162

174-
/** How often to check that node managers are still alive.*/
175-
public static final String RM_NM_LIVENESS_MONITOR_INTERVAL_MS =
176-
RM_PREFIX + "nm.liveness-monitor.interval-ms";
177-
public static final int DEFAULT_RM_NM_LIVENESS_MONITOR_INTERVAL_MS = 1000;
163+
/** How long to wait until a container is considered dead.*/
164+
public static final String RM_CONTAINER_ALLOC_EXPIRY_INTERVAL_MS =
165+
RM_PREFIX + "rm.container-allocation.expiry-interval-ms";
166+
public static final int DEFAULT_RM_CONTAINER_ALLOC_EXPIRY_INTERVAL_MS = 600000;
178167

179168
/** Path to file with nodes to include.*/
180169
public static final String RM_NODES_INCLUDE_FILE_PATH =

hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/NMLivelinessMonitor.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,10 @@ public NMLivelinessMonitor(Dispatcher d) {
3939

4040
public void init(Configuration conf) {
4141
super.init(conf);
42-
setExpireInterval(conf.getInt(YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS,
43-
YarnConfiguration.DEFAULT_RM_NM_EXPIRY_INTERVAL_MS));
44-
setMonitorInterval(conf.getInt(
45-
YarnConfiguration.RM_NM_LIVENESS_MONITOR_INTERVAL_MS,
46-
YarnConfiguration.DEFAULT_RM_NM_LIVENESS_MONITOR_INTERVAL_MS));
42+
int expireIntvl = conf.getInt(YarnConfiguration.RM_NM_EXPIRY_INTERVAL_MS,
43+
YarnConfiguration.DEFAULT_RM_NM_EXPIRY_INTERVAL_MS);
44+
setExpireInterval(expireIntvl);
45+
setMonitorInterval(expireIntvl/3);
4746
}
4847

4948
@Override

hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmapp/attempt/AMLivelinessMonitor.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -37,10 +37,10 @@ public AMLivelinessMonitor(Dispatcher d) {
3737

3838
public void init(Configuration conf) {
3939
super.init(conf);
40-
setExpireInterval(conf.getInt(YarnConfiguration.RM_AM_EXPIRY_INTERVAL_MS,
41-
YarnConfiguration.DEFAULT_RM_AM_EXPIRY_INTERVAL_MS));
42-
setMonitorInterval(conf.getInt(YarnConfiguration.RM_AM_LIVENESS_MONITOR_INTERVAL_MS,
43-
YarnConfiguration.DEFAULT_RM_AM_LIVENESS_MONITOR_INTERVAL_MS));
40+
int expireIntvl = conf.getInt(YarnConfiguration.RM_AM_EXPIRY_INTERVAL_MS,
41+
YarnConfiguration.DEFAULT_RM_AM_EXPIRY_INTERVAL_MS);
42+
setExpireInterval(expireIntvl);
43+
setMonitorInterval(expireIntvl/3);
4444
}
4545

4646
@Override

hadoop-mapreduce-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/rmcontainer/ContainerAllocationExpirer.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,11 @@ public ContainerAllocationExpirer(Dispatcher d) {
3939

4040
public void init(Configuration conf) {
4141
super.init(conf);
42-
setExpireInterval(conf.getInt(
43-
YarnConfiguration.RM_CONTAINER_LIVENESS_MONITOR_INTERVAL_MS,
44-
YarnConfiguration.DEFAULT_RM_CONTAINER_LIVENESS_MONITOR_INTERVAL_MS));
45-
setMonitorInterval(conf.getInt(YarnConfiguration.RM_AM_LIVENESS_MONITOR_INTERVAL_MS,
46-
YarnConfiguration.DEFAULT_RM_AM_LIVENESS_MONITOR_INTERVAL_MS));
42+
int expireIntvl = conf.getInt(
43+
YarnConfiguration.RM_CONTAINER_ALLOC_EXPIRY_INTERVAL_MS,
44+
YarnConfiguration.DEFAULT_RM_CONTAINER_ALLOC_EXPIRY_INTERVAL_MS);
45+
setExpireInterval(expireIntvl);
46+
setMonitorInterval(expireIntvl/3);
4747
}
4848

4949
@Override

0 commit comments

Comments
 (0)