Skip to content

Commit 6912a41

Browse files
adchiagitbook-bot
authored andcommitted
GitBook: [feast-dev#314] Remove data creator cleanup since it breaks tests (from 0.14 branch)
1 parent 2541c91 commit 6912a41

File tree

1 file changed

+4
-7
lines changed

1 file changed

+4
-7
lines changed

docs/how-to-guides/adding-or-reusing-tests.md

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -150,9 +150,9 @@ The key fixtures are the `environment` and `universal_data_sources` fixtures, wh
150150

151151
To:
152152

153-
* Include a new offline store:
153+
* Include a new offline store: 
154154
* extend `data_source_creator.py` for your offline store
155-
* in `repo_configuration.py` add a new`IntegrationTestRepoConfig` or two \(depending on how many online stores you want to test\)
155+
* in `repo_configuration.py` add a new`IntegrationTestRepoConfig` or two (depending on how many online stores you want to test)
156156
* Run the full test suite with `make test-python-integration`
157157
* See more guidelines at [https://github.com/feast-dev/feast/issues/1892](https://github.com/feast-dev/feast/issues/1892)
158158
* Include a new online store:
@@ -161,10 +161,10 @@ To:
161161
* Run the full test suite with `make test-python-integration`
162162
* See more guidelines at [https://github.com/feast-dev/feast/issues/1892](https://github.com/feast-dev/feast/issues/1892)
163163
* Add a new test to an existing test file:
164-
* Use the same function signatures as an existing test \(e.g. have environment as an argument\) to include the relevant test fixtures.
164+
* Use the same function signatures as an existing test (e.g. have environment as an argument) to include the relevant test fixtures. 
165165
* We prefer to expand what an individual test covers due to the cost of standing up offline / online stores
166166
* Using custom data in a new test:
167-
* This is used in several places such as `test_universal_types.py`
167+
* This is used in several places such as `test_universal_types.py` 
168168

169169
```python
170170

@@ -180,7 +180,4 @@ def your_test(environment: Environment):
180180
fs.apply([fv, entity])
181181

182182
# ... run test
183-
184-
environment.data_source_creator.teardown()
185183
```
186-

0 commit comments

Comments
 (0)