Skip to content

Commit a61ec26

Browse files
author
Null McNull
committed
changed block-ui link from post to pre
1 parent edb0990 commit a61ec26

File tree

2 files changed

+18
-15
lines changed

2 files changed

+18
-15
lines changed

src/angular-block-ui/block-ui-directive.js

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,15 +5,18 @@ blkUI.directive('blockUi', function(blockUiCompileFn) {
55
compile: blockUiCompileFn
66
};
77

8-
}).factory('blockUiCompileFn', function(blockUiLinkFn) {
8+
}).factory('blockUiCompileFn', function(blockUiPreLinkFn) {
99

1010
return function($element, $attrs) {
1111
$element.append('<div block-ui-container></div>');
1212

13-
return blockUiLinkFn;
13+
return {
14+
pre: blockUiPreLinkFn
15+
};
16+
1417
};
1518

16-
}).factory('blockUiLinkFn', function(blockUI, blockUIUtils, blockUIConfig) {
19+
}).factory('blockUiPreLinkFn', function(blockUI, blockUIUtils) {
1720

1821
return function($scope, $element, $attrs) {
1922

src/angular-block-ui/block-ui-directive.test.js

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
describe('block-ui-directive', function() {
22

3-
var $ = angular.element, $attrs = {}, $compile, $scope, blockUI, $timeout, config, configCopy, linkFn, compileFn;
3+
var $ = angular.element, $attrs = {}, $compile, $scope, blockUI, $timeout, config, configCopy, preLinkFn, compileFn;
44

55
beforeEach(function() {
66
module('blockUI');
77

8-
inject(function(_blockUI_, _$timeout_, _$rootScope_, _$compile_, blockUIConfig, blockUiLinkFn, blockUiCompileFn) {
8+
inject(function(_blockUI_, _$timeout_, _$rootScope_, _$compile_, blockUIConfig, blockUiPreLinkFn, blockUiCompileFn) {
99

1010
blockUI = _blockUI_;
1111
$timeout = _$timeout_;
1212
$compile = _$compile_;
1313
$scope = _$rootScope_.$new();
1414
config = blockUIConfig;
15-
linkFn = blockUiLinkFn;
15+
preLinkFn = blockUiPreLinkFn;
1616
compileFn = blockUiCompileFn;
1717

1818
});
@@ -56,7 +56,7 @@ describe('block-ui-directive', function() {
5656

5757
var $element = $('<div></div>');
5858

59-
linkFn($scope, $element, $attrs);
59+
preLinkFn($scope, $element, $attrs);
6060

6161
var result = $element.hasClass('block-ui');
6262

@@ -70,7 +70,7 @@ describe('block-ui-directive', function() {
7070

7171
var $element = $('<div></div>');
7272

73-
linkFn($scope, $element, $attrs);
73+
preLinkFn($scope, $element, $attrs);
7474

7575
var result = $element.data('block-ui');
7676

@@ -89,7 +89,7 @@ describe('block-ui-directive', function() {
8989

9090
var $element = $('<div></div>');
9191

92-
linkFn($scope, $element, $attrs);
92+
preLinkFn($scope, $element, $attrs);
9393

9494
expect(blockUI.instances[expectedId]).toBeDefined();
9595
});
@@ -99,7 +99,7 @@ describe('block-ui-directive', function() {
9999
var $element = $('<div></div>');
100100

101101
$attrs.blockUi = 'testInstance';
102-
linkFn($scope, $element, $attrs);
102+
preLinkFn($scope, $element, $attrs);
103103

104104
var expected = blockUI.instances.get('testInstance');
105105
var result = $element.data('block-ui');
@@ -130,7 +130,7 @@ describe('block-ui-directive', function() {
130130

131131
// act
132132

133-
linkFn($scope, $element, $attrs);
133+
preLinkFn($scope, $element, $attrs);
134134

135135
// assert
136136

@@ -159,7 +159,7 @@ describe('block-ui-directive', function() {
159159

160160
var $element = $('<div></div>');
161161

162-
linkFn($scope, $element, { blockUi: instanceName });
162+
preLinkFn($scope, $element, { blockUi: instanceName });
163163

164164
expect(instance._refs).toBe(1);
165165

@@ -169,7 +169,7 @@ describe('block-ui-directive', function() {
169169

170170
var $element = $('<div></div>');
171171

172-
linkFn($scope, $element, { blockUi: instanceName });
172+
preLinkFn($scope, $element, { blockUi: instanceName });
173173

174174
spyOn(instance, 'release').andCallThrough();
175175
spyOn(blockUI.instances, '_destroy');
@@ -191,7 +191,7 @@ describe('block-ui-directive', function() {
191191
var $element = $('<div></div>');
192192
var pattern = '^\/api\/quote($|\/).*';
193193

194-
linkFn($scope, $element, { blockUi: 'myInstance', blockUiPattern: '/' + pattern + '/' });
194+
preLinkFn($scope, $element, { blockUi: 'myInstance', blockUiPattern: '/' + pattern + '/' });
195195

196196
var instance = blockUI.instances.myInstance;
197197

@@ -207,7 +207,7 @@ describe('block-ui-directive', function() {
207207

208208
var blockInstance = blockUI.instances.get('myInstance');
209209
var $element = $('<div></div>');
210-
linkFn($scope, $element, { blockUi: 'myInstance' });
210+
preLinkFn($scope, $element, { blockUi: 'myInstance' });
211211

212212
blockInstance.start();
213213
$timeout.flush(); // skip the delay of the block

0 commit comments

Comments
 (0)