Skip to content

Commit f4dee20

Browse files
author
Daniel Hiltgen
committed
Merge commit '6096a1a39eb1ec6878c797b45afbe0e48410eda0' into rsampaio_conn_fix
Conflicts: kvm.go
2 parents 936173f + 6096a1a commit f4dee20

File tree

2 files changed

+13
-9
lines changed

2 files changed

+13
-9
lines changed

bin/main.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ import (
66
)
77

88
func main() {
9-
plugin.RegisterDriver(kvm.NewDriver())
9+
plugin.RegisterDriver(kvm.NewDriver("default", "path"))
1010
}

kvm.go

Lines changed: 12 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ func (d *Driver) DriverName() string {
162162
}
163163

164164
func (d *Driver) SetConfigFromFlags(flags drivers.DriverOptions) error {
165-
log.Debugf("SetConfigFromFlags aclled")
165+
log.Debugf("SetConfigFromFlags called")
166166
d.Memory = flags.Int("kvm-memory")
167167
d.DiskSize = flags.Int("kvm-disk-size")
168168
d.CPU = flags.Int("kvm-cpu-count")
@@ -274,7 +274,6 @@ func (d *Driver) validateNetwork(name string) error {
274274
func (d *Driver) PreCreateCheck() error {
275275
// TODO We could look at d.conn.GetCapabilities()
276276
// parse the XML, and look for kvm
277-
278277
log.Debug("About to check libvirt version")
279278

280279
// TODO might want to check minimum version
@@ -670,14 +669,19 @@ func createDiskImage(dest string, size int, r io.Reader) error {
670669
return f.Close()
671670
}
672671

673-
func NewDriver() *Driver {
674-
d := &Driver{}
675-
conn, err := libvirt.NewVirConnection(d.connectionString)
672+
func NewDriver(hostName, storePath string) drivers.Driver {
673+
conn, err := libvirt.NewVirConnection(connectionString)
676674
if err != nil {
677675
log.Errorf("Failed to connect to libvirt: %s", err)
678676
os.Exit(1)
679677
}
680-
d.conn = &conn
681-
d.PrivateNetwork = privateNetworkName
682-
return d
678+
679+
return &Driver{
680+
conn: &conn,
681+
PrivateNetwork: privateNetworkName,
682+
BaseDriver: &drivers.BaseDriver{
683+
MachineName: hostName,
684+
StorePath: storePath,
685+
},
686+
}
683687
}

0 commit comments

Comments
 (0)