simplify spring demo

Author: nobodyiam

apollo-demo/src/main/java/com/ctrip/framework/apollo/demo/spring/common/bean/AnnotatedBean.java

@@ -1,70 +1,39 @@
 package com.ctrip.framework.apollo.demo.spring.common.bean;
 
-import com.ctrip.framework.apollo.Config;
-import com.ctrip.framework.apollo.model.ConfigChange;
-import com.ctrip.framework.apollo.model.ConfigChangeEvent;
-import com.ctrip.framework.apollo.spring.annotation.ApolloConfig;
-import com.ctrip.framework.apollo.spring.annotation.ApolloConfigChangeListener;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Value;
+import org.springframework.cloud.context.config.annotation.RefreshScope;
 import org.springframework.stereotype.Component;
 
 import javax.annotation.PostConstruct;
 
 /**
  * @author Jason Song([email protected])
  */
-@Component
+@RefreshScope
+@Component("annotatedBean")
 public class AnnotatedBean {
   private static final Logger logger = LoggerFactory.getLogger(AnnotatedBean.class);
 
   @Value("${timeout:200}")
   private int timeout;
   private int batch;
 
-  @ApolloConfig
-  private Config config;
-  @ApolloConfig("FX.apollo")
-  private Config anotherConfig;
-
   @PostConstruct
   void initialize() {
-    logger.info("timeout is {}", timeout);
-    logger.info("batch is {}", batch);
-
-    logger.info("Keys for config: {}", config.getPropertyNames());
-    logger.info("Keys for anotherConfig: {}", anotherConfig.getPropertyNames());
+    logger.info("timeout is initialized as {}", timeout);
+    logger.info("batch is initialized as {}", batch);
   }
 
   @Value("${batch:100}")
   public void setBatch(int batch) {
     this.batch = batch;
   }
 
-  @ApolloConfigChangeListener("application")
-  private void someChangeHandler(ConfigChangeEvent changeEvent) {
-    logger.info("[someChangeHandler]Changes for namespace {}", changeEvent.getNamespace());
-    if (changeEvent.isChanged("timeout")) {
-      refreshTimeout();
-    }
-  }
-
-  @ApolloConfigChangeListener({"application", "FX.apollo"})
-  private void anotherChangeHandler(ConfigChangeEvent changeEvent) {
-    logger.info("[anotherChangeHandler]Changes for namespace {}", changeEvent.getNamespace());
-    for (String key : changeEvent.changedKeys()) {
-      ConfigChange change = changeEvent.getChange(key);
-      logger.info("[anotherChangeHandler]Change - key: {}, oldValue: {}, newValue: {}, changeType: {}",
-          change.getPropertyName(), change.getOldValue(), change.getNewValue(),
-          change.getChangeType());
-    }
-  }
 
-  private void refreshTimeout() {
-    //do some custom logic to update placeholder value
-    timeout = config.getIntProperty("timeout", timeout);
-    logger.info("Refreshing timeout to {}", timeout);
+  @Override
+  public String toString() {
+    return String.format("[AnnotatedBean] timeout: %d, batch: %d", timeout, batch);
   }
 }

apollo-demo/src/main/java/com/ctrip/framework/apollo/demo/spring/common/bean/NormalBean.java

@@ -1,11 +1,7 @@
 package com.ctrip.framework.apollo.demo.spring.common.config;
 
-import com.ctrip.framework.apollo.demo.spring.common.bean.NormalBean;
 import com.ctrip.framework.apollo.spring.annotation.EnableApolloConfig;
 
-import org.springframework.beans.factory.annotation.Value;
-import org.springframework.cloud.context.config.annotation.RefreshScope;
-import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 
 /**
@@ -14,11 +10,4 @@
 @Configuration
 @EnableApolloConfig(value = "application", order = 10)
 public class AppConfig {
-  @Bean("normalBean")
-  @RefreshScope
-  public NormalBean normalBean(@Value("${batch:100}") int batch) {
-    NormalBean bean = new NormalBean();
-    bean.setBatch(batch);
-    return bean;
-  }
 }

apollo-demo/src/main/java/com/ctrip/framework/apollo/demo/spring/common/bean/RefreshScopeBean.java

@@ -1,58 +1,37 @@
 package com.ctrip.framework.apollo.demo.spring.common.refresh;
 
-import com.ctrip.framework.apollo.Config;
-import com.ctrip.framework.apollo.ConfigChangeListener;
-import com.ctrip.framework.apollo.demo.spring.common.bean.NormalBean;
-import com.ctrip.framework.apollo.demo.spring.common.bean.RefreshScopeBean;
+import com.ctrip.framework.apollo.demo.spring.common.bean.AnnotatedBean;
 import com.ctrip.framework.apollo.model.ConfigChangeEvent;
-import com.ctrip.framework.apollo.spring.annotation.ApolloConfig;
+import com.ctrip.framework.apollo.spring.annotation.ApolloConfigChangeListener;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.beans.factory.annotation.Qualifier;
 import org.springframework.cloud.context.scope.refresh.RefreshScope;
 import org.springframework.stereotype.Component;
 
-import javax.annotation.PostConstruct;
-
 /**
  * To refresh the config bean when config is changed
  *
  * @author Jason Song([email protected])
  */
 @Component
-public class ApolloRefreshConfig implements ConfigChangeListener {
+public class ApolloRefreshConfig {
   private static final Logger logger = LoggerFactory.getLogger(ApolloRefreshConfig.class);
 
-  @ApolloConfig
-  private Config config;
-  @ApolloConfig("FX.apollo")
-  private Config anotherConfig;
   @Autowired
   private RefreshScope refreshScope;
 
   @Autowired
-  private RefreshScopeBean refreshScopeBean;
-
-  @Autowired
-  private NormalBean normalBean;
-
-  @PostConstruct
-  private void init() {
-    config.addChangeListener(this);
-    anotherConfig.addChangeListener(this);
-  }
-
-  @Override
-  public void onChange(ConfigChangeEvent changeEvent) {
-    //could also call refreshScope.refreshAll();
-    logger.info("refreshScopeBean before refresh {}", refreshScopeBean.toString());
-    //could also call refreshScope.refreshAll();
-    refreshScope.refresh("refreshScopeBean");
-    logger.info("refreshScopeBean after refresh {}", refreshScopeBean.toString());
-    logger.info("normalBean with refresh scope before refresh {}", normalBean.toString());
-    refreshScope.refresh("normalBean");
-    logger.info("normalBean with refresh scope after refresh {}", normalBean.toString());
+  private AnnotatedBean annotatedBean;
+
+  @ApolloConfigChangeListener({"application", "FX.apollo"})
+  private void onChange(ConfigChangeEvent changeEvent) {
+    if (changeEvent.isChanged("timeout") || changeEvent.isChanged("batch")) {
+      logger.info("before refresh {}", annotatedBean.toString());
+      //could also call refreshScope.refreshAll();
+      refreshScope.refresh("annotatedBean");
+      logger.info("after refresh {}", annotatedBean.toString());
+    }
   }
 }

apollo-demo/src/main/java/com/ctrip/framework/apollo/demo/spring/common/config/AppConfig.java

@@ -1,9 +1,6 @@
 package com.ctrip.framework.apollo.demo.spring.javaConfigDemo.config;
 
-import com.ctrip.framework.apollo.demo.spring.common.refresh.ApolloRefreshConfig;
-
 import org.springframework.cloud.autoconfigure.RefreshAutoConfiguration;
-import org.springframework.context.annotation.Bean;
 import org.springframework.context.annotation.Configuration;
 import org.springframework.context.annotation.Import;
 

apollo-demo/src/main/java/com/ctrip/framework/apollo/demo/spring/common/refresh/ApolloRefreshConfig.java

@@ -1,8 +1,5 @@
 package com.ctrip.framework.apollo.demo.spring.springBootDemo.config;
 
-import com.ctrip.framework.apollo.ConfigChangeListener;
-import com.ctrip.framework.apollo.model.ConfigChangeEvent;
-
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.boot.context.properties.ConfigurationProperties;
@@ -25,8 +22,8 @@ public class SampleRedisConfig {
   private int commandTimeout;
 
   @PostConstruct
-  private void init() {
-    logger.info("ConfigurationProperties sample - expireSeconds: {}, clusterNodes: {}, commandTimeout: {}",
+  private void initialize() {
+    logger.info("SampleRedisConfig initialized - expireSeconds: {}, clusterNodes: {}, commandTimeout: {}",
         expireSeconds, clusterNodes, commandTimeout);
   }
 

apollo-demo/src/main/java/com/ctrip/framework/apollo/demo/spring/javaConfigDemo/config/RefreshScopeConfig.java

@@ -1,25 +1,21 @@
 package com.ctrip.framework.apollo.demo.spring.springBootDemo.refresh;
 
-import com.ctrip.framework.apollo.Config;
-import com.ctrip.framework.apollo.ConfigChangeListener;
 import com.ctrip.framework.apollo.demo.spring.common.refresh.ApolloRefreshConfig;
 import com.ctrip.framework.apollo.demo.spring.springBootDemo.config.SampleRedisConfig;
 import com.ctrip.framework.apollo.model.ConfigChangeEvent;
-import com.ctrip.framework.apollo.spring.annotation.ApolloConfig;
+import com.ctrip.framework.apollo.spring.annotation.ApolloConfigChangeListener;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.cloud.context.scope.refresh.RefreshScope;
 import org.springframework.stereotype.Component;
 
-import javax.annotation.PostConstruct;
-
 /**
  * @author Jason Song([email protected])
  */
 @Component
-public class SpringBootApolloRefreshConfig implements ConfigChangeListener {
+public class SpringBootApolloRefreshConfig {
   private static final Logger logger = LoggerFactory.getLogger(SpringBootApolloRefreshConfig.class);
 
   @Autowired
@@ -28,21 +24,13 @@ public class SpringBootApolloRefreshConfig implements ConfigChangeListener {
   @Autowired
   private SampleRedisConfig sampleRedisConfig;
 
-  @ApolloConfig
-  private Config config;
-
   @Autowired
   private RefreshScope refreshScope;
 
-  @PostConstruct
-  private void init() {
-    config.addChangeListener(this);
-  }
-
-  @Override
+  @ApolloConfigChangeListener
   public void onChange(ConfigChangeEvent changeEvent) {
-    logger.info("sampleRedisConfig before refresh {}", sampleRedisConfig.toString());
+    logger.info("before refresh {}", sampleRedisConfig.toString());
     refreshScope.refresh("sampleRedisConfig");
-    logger.info("sampleRedisConfig after refresh {}", sampleRedisConfig.toString());
+    logger.info("after refresh {}", sampleRedisConfig.toString());
   }
 }

apollo-demo/src/main/java/com/ctrip/framework/apollo/demo/spring/springBootDemo/config/SampleRedisConfig.java

@@ -0,0 +1,32 @@
+package com.ctrip.framework.apollo.demo.spring.xmlConfigDemo.bean;
+
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+/**
+ * @author Jason Song([email protected])
+ */
+public class XmlBean {
+  private static final Logger logger = LoggerFactory.getLogger(XmlBean.class);
+
+  private int timeout;
+  private int batch;
+
+  public void setTimeout(int timeout) {
+    logger.info("updating timeout, old value: {}, new value: {}", this.timeout, timeout);
+    this.timeout = timeout;
+  }
+
+  public void setBatch(int batch) {
+    logger.info("updating batch, old value: {}, new value: {}", this.batch, batch);
+    this.batch = batch;
+  }
+
+  public int getTimeout() {
+    return timeout;
+  }
+
+  public int getBatch() {
+    return batch;
+  }
+}