Merge pull request dingo#1102 from lucasmichot/feature/master/etag-sha

Use sha1 to avoid collisions

Author: hskrasek

src/Http/RateLimit/Handler.php

@@ -103,7 +103,7 @@ public function rateLimitRequest(Request $request, $limit = 0, $expires = 0)
         } elseif ($limit > 0 || $expires > 0) {
             $this->throttle = new Route(['limit' => $limit, 'expires' => $expires]);
 
-            $this->keyPrefix = md5($request->path());
+            $this->keyPrefix = sha1($request->path());
 
         // Otherwise we'll use the throttle that gives the consumer the largest
         // amount of requests. If no matching throttle is found then rate

src/Routing/Router.php

@@ -622,7 +622,7 @@ protected function prepareResponse($response, Request $request, $format)
 
         if ($response->isSuccessful() && $this->requestIsConditional()) {
             if (! $response->headers->has('ETag')) {
-                $response->setEtag(md5($response->getContent()));
+                $response->setEtag(sha1($response->getContent()));
             }
 
             $response->isNotModified($request);

tests/Routing/RouterTest.php

@@ -173,18 +173,18 @@ public function testRouterPreparesNotModifiedResponse()
         $response = $this->router->dispatch($request);
 
         $this->assertSame(200, $response->getStatusCode());
-        $this->assertSame('"'.md5('bar').'"', $response->getETag());
+        $this->assertSame('"'.sha1('bar').'"', $response->getETag());
         $this->assertSame('bar', $response->getContent());
 
         $request = $this->createRequest('foo', 'GET', [
-            'if-none-match' => '"'.md5('bar').'"',
+            'if-none-match' => '"'.sha1('bar').'"',
             'accept' => 'application/vnd.api.v1+json',
         ]);
 
         $response = $this->router->dispatch($request);
 
         $this->assertSame(304, $response->getStatusCode());
-        $this->assertSame('"'.md5('bar').'"', $response->getETag());
+        $this->assertSame('"'.sha1('bar').'"', $response->getETag());
         $this->assertEmpty($response->getContent());
 
         $request = $this->createRequest('foo', 'GET', [
@@ -195,7 +195,7 @@ public function testRouterPreparesNotModifiedResponse()
         $response = $this->router->dispatch($request);
 
         $this->assertSame(200, $response->getStatusCode());
-        $this->assertSame('"'.md5('bar').'"', $response->getETag());
+        $this->assertSame('"'.sha1('bar').'"', $response->getETag());
         $this->assertSame('bar', $response->getContent());
     }