BUG 22900099 - MAX VALUE FOR IDLE_WORKER_THREAD_TIMEOUT SHOULD BE 1 HOUR.

    Description:
    The max value for the idle_worker_thread_timeout system variable was value of maximum unsigned int. This was changed to more reasonable 1h value.

    RB: 12070
    Reviewed by: Grzegorz Szwarc <[email protected]>
    Reviewed by: Lukasz Kotula <[email protected]>

(cherry picked from commit 583d58d2f8589081fa0b6104a0e5b015ba3ee87c)

Author: Andrzej Religa

mysql-test/suite/xplugin/r/mysqlx_server_var.result

@@ -55,6 +55,10 @@ SET @@global.mysqlx_idle_worker_thread_timeout=7;
 show variables like 'mysqlx_idle_worker_thread_timeout';
 Variable_name	Value
 mysqlx_idle_worker_thread_timeout	7
+SET @@global.mysqlx_idle_worker_thread_timeout=3600;
+show variables like 'mysqlx_idle_worker_thread_timeout';
+Variable_name	Value
+mysqlx_idle_worker_thread_timeout	3600
 SET mysqlx_idle_worker_thread_timeout=7;
 ERROR HY000: Variable 'mysqlx_idle_worker_thread_timeout' is a GLOBAL variable and should be set with SET GLOBAL
 SET @@local.mysqlx_idle_worker_thread_timeout=7;
@@ -65,6 +69,9 @@ SET @@session.mysqlx_idle_worker_thread_timeout=7;
 ERROR HY000: Variable 'mysqlx_idle_worker_thread_timeout' is a GLOBAL variable and should be set with SET GLOBAL
 SET SESSION mysqlx_idle_worker_thread_timeout=7;
 ERROR HY000: Variable 'mysqlx_idle_worker_thread_timeout' is a GLOBAL variable and should be set with SET GLOBAL
+SET @@global.mysqlx_idle_worker_thread_timeout=3601;
+Warnings:
+Warning	1292	Truncated incorrect mysqlx_idle_worker_thread_timeou value: '3601'
 SET GLOBAL mysqlx_idle_worker_thread_timeout=0;
 SET GLOBAL mysqlx_idle_worker_thread_timeout=-1;
 Warnings:

mysql-test/suite/xplugin/t/mysqlx_server_var.test

@@ -73,6 +73,9 @@ show variables like 'mysqlx_idle_worker_thread_timeout';
 SET GLOBAL mysqlx_idle_worker_thread_timeout=7;
 SET @@global.mysqlx_idle_worker_thread_timeout=7;
 show variables like 'mysqlx_idle_worker_thread_timeout';
+#Max valid value
+SET @@global.mysqlx_idle_worker_thread_timeout=3600;
+show variables like 'mysqlx_idle_worker_thread_timeout';
 
 ## Invalid cases
 --error ER_GLOBAL_VARIABLE
@@ -85,6 +88,8 @@ SET @@mysqlx_idle_worker_thread_timeout=7;
 SET @@session.mysqlx_idle_worker_thread_timeout=7;
 --error ER_GLOBAL_VARIABLE
 SET SESSION mysqlx_idle_worker_thread_timeout=7;
+# Warning: Truncated incorrect mysqlx_idle_worker_thread_timeout value
+SET @@global.mysqlx_idle_worker_thread_timeout=3601;
 
 #--error ER_GLOBAL_VARIABLE
 SET GLOBAL mysqlx_idle_worker_thread_timeout=0;

rapid/plugin/x/src/xpl_plugin.cc

@@ -136,7 +136,7 @@ static MYSQL_SYSVAR_UINT(min_worker_threads, xpl::Plugin_system_variables::min_w
 static MYSQL_SYSVAR_UINT(idle_worker_thread_timeout, xpl::Plugin_system_variables::idle_worker_thread_timeout,
     PLUGIN_VAR_OPCMDARG,
     "Time after which an idle worker thread is terminated (in seconds).",
-    NULL, &xpl::Plugin_system_variables::update_func<unsigned int>, 60, 0, std::numeric_limits<unsigned int>::max(), 0);
+    NULL, &xpl::Plugin_system_variables::update_func<unsigned int>, 60, 0, 60 * 60, 0);
 
 static MYSQL_SYSVAR_UINT(max_allowed_packet, xpl::Plugin_system_variables::max_allowed_packet,
     PLUGIN_VAR_OPCMDARG,