Skip to content

Commit 9dcf987

Browse files
committed
renamed to requireAll to scopeStrict
1 parent 481c9ad commit 9dcf987

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

src/Auth/Provider/OAuth2.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ public function authenticate(Request $request, Route $route)
8181

8282
$token = $this->resource->getAccessToken();
8383

84-
if ($route->requiresAllScopes()) {
84+
if ($route->scopeStrict()) {
8585
$this->validateAllRouteScopes($token, $route);
8686
} else {
8787
$this->validateAnyRouteScopes($token, $route);

src/Routing/Route.php

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -353,13 +353,14 @@ public function getScopes()
353353
}
354354

355355
/**
356-
* Check if route requires any or all scopes
356+
* Check if route requires all scopes
357+
* or any scope to be valid.
357358
*
358359
* @return bool
359360
*/
360-
public function requiresAllScopes()
361+
public function scopeStrict()
361362
{
362-
return array_get($this->action, 'requireAll', false);
363+
return array_get($this->action, 'scopeStrict', false);
363364
}
364365

365366
/**

tests/Auth/Provider/OAuth2Test.php

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ public function testExceptionThrownWhenNoScopesProvided()
3636

3737
$route = m::mock('Dingo\Api\Routing\Route');
3838
$route->shouldReceive('scopes')->once()->andReturn(['foo']);
39-
$route->shouldReceive('requiresAllScopes')->once()->andReturn(false);
39+
$route->shouldReceive('scopeStrict')->once()->andReturn(false);
4040

4141
$this->provider->authenticate($request, $route);
4242
}
@@ -63,7 +63,7 @@ public function testOnlyOneScopeRequiredToValidateCorrectlyIfRequiredAllSetToFal
6363

6464
$route = m::mock('Dingo\Api\Routing\Route');
6565
$route->shouldReceive('scopes')->once()->andReturn(['foo', 'bar']);
66-
$route->shouldReceive('requiresAllScopes')->once()->andReturn(false);
66+
$route->shouldReceive('scopeStrict')->once()->andReturn(false);
6767

6868
$this->assertNull($this->provider->authenticate($request, $route));
6969
}
@@ -76,19 +76,19 @@ public function testAllScopeRequiredToValidateCorrectlyIfRequiredAllSetToTrue()
7676
$request = Request::create('GET', '/', [], [], [], ['HTTP_AUTHORIZATION' => 'Bearer 12345']);
7777

7878
$this->server->shouldReceive('isValidRequest')->once()->andReturn(true);
79-
79+
8080
$token = m::mock('League\OAuth2\Server\Entity\AccessTokenEntity');
8181
$token->shouldReceive('hasScope')->once()->with('foo')->andReturn(true);
8282
$token->shouldReceive('hasScope')->once()->with('bar')->andReturn(false);
8383
$this->server->shouldReceive('getAccessToken')->once()->andReturn($token);
84-
84+
8585
$this->provider->setClientResolver(function ($id) {
8686
//
8787
});
88-
88+
8989
$route = m::mock('Dingo\Api\Routing\Route');
9090
$route->shouldReceive('scopes')->once()->andReturn(['foo', 'bar']);
91-
$route->shouldReceive('requiresAllScopes')->once()->andReturn(true);
91+
$route->shouldReceive('scopeStrict')->once()->andReturn(true);
9292

9393
$this->provider->authenticate($request, $route);
9494
}
@@ -114,7 +114,7 @@ public function testClientIsResolved()
114114

115115
$route = m::mock('Dingo\Api\Routing\Route');
116116
$route->shouldReceive('scopes')->once()->andReturn([]);
117-
$route->shouldReceive('requiresAllScopes')->once()->andReturn(false);
117+
$route->shouldReceive('scopeStrict')->once()->andReturn(false);
118118

119119
$this->assertEquals('foo', $this->provider->authenticate($request, $route));
120120
}
@@ -140,7 +140,7 @@ public function testUserIsResolved()
140140

141141
$route = m::mock('Dingo\Api\Routing\Route');
142142
$route->shouldReceive('scopes')->once()->andReturn([]);
143-
$route->shouldReceive('requiresAllScopes')->once()->andReturn(false);
143+
$route->shouldReceive('scopeStrict')->once()->andReturn(false);
144144

145145
$this->assertEquals('foo', $this->provider->authenticate($request, $route));
146146
}

0 commit comments

Comments
 (0)