Skip to content

Commit 5c47714

Browse files
committed
Avoid touching CFLAGS unless explicitly requested (rbenv#352)
1 parent 9f8d533 commit 5c47714

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

bin/ruby-build

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -378,8 +378,13 @@ build_package_standard() {
378378
local PACKAGE_MAKE_OPTS_ARRAY="${package_var_name}_MAKE_OPTS_ARRAY[@]"
379379
local PACKAGE_CFLAGS="${package_var_name}_CFLAGS"
380380

381-
{ CFLAGS="$CFLAGS ${!PACKAGE_CFLAGS}" ${!PACKAGE_CONFIGURE:-./configure} --prefix="${!PACKAGE_PREFIX_PATH:-$PREFIX_PATH}" $CONFIGURE_OPTS ${!PACKAGE_CONFIGURE_OPTS} "${!PACKAGE_CONFIGURE_OPTS_ARRAY}"
382-
"$MAKE" $MAKE_OPTS ${!PACKAGE_MAKE_OPTS} "${!PACKAGE_MAKE_OPTS_ARRAY}"
381+
( if [ "${CFLAGS+defined}" ] || [ "${!PACKAGE_CFLAGS+defined}" ]; then
382+
export CFLAGS="$CFLAGS {$!PACKAGE_CFLAGS}"
383+
fi
384+
${!PACKAGE_CONFIGURE:-./configure} --prefix="${!PACKAGE_PREFIX_PATH:-$PREFIX_PATH}" $CONFIGURE_OPTS ${!PACKAGE_CONFIGURE_OPTS} "${!PACKAGE_CONFIGURE_OPTS_ARRAY}"
385+
) >&4 2>&1
386+
387+
{ "$MAKE" $MAKE_OPTS ${!PACKAGE_MAKE_OPTS} "${!PACKAGE_MAKE_OPTS_ARRAY}"
383388
"$MAKE" install
384389
} >&4 2>&1
385390
}

0 commit comments

Comments
 (0)