Skip to content

Commit 59e69c3

Browse files
authored
chore: use esbuild script for vscode tasks (denoland#597)
1 parent 7d13d49 commit 59e69c3

File tree

3 files changed

+9
-20
lines changed

3 files changed

+9
-20
lines changed

.vscode/tasks.json

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"tasks": [
44
{
55
"type": "npm",
6-
"script": "compile",
6+
"script": "esbuild",
77
"group": "build",
88
"presentation": {
99
"panel": "dedicated",
@@ -12,22 +12,6 @@
1212
"problemMatcher": [
1313
"$tsc"
1414
]
15-
},
16-
{
17-
"type": "npm",
18-
"script": "watch",
19-
"isBackground": true,
20-
"group": {
21-
"kind": "build",
22-
"isDefault": true
23-
},
24-
"presentation": {
25-
"panel": "dedicated",
26-
"reveal": "never"
27-
},
28-
"problemMatcher": [
29-
"$tsc-watch"
30-
]
3115
}
3216
]
3317
}

README.md

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -153,8 +153,14 @@ steps:
153153

154154
1. Open this folder in VS Code.
155155
2. Run `npm i`.
156-
3. Run `npm run compile`.
157-
4. Run the `Launch Client` launch task from the VSCode debug menu.
156+
3. Run the `Launch Client` launch task from the VSCode debug menu.
157+
158+
After making changes to the extension you can use the restart button in the
159+
VSCode debug menu, this makes a new build and reloads the client.
160+
161+
Note that if you already have the deno extension installed from the VSCode
162+
Marketplace, it will be replaced for the `Launch Client` instance only. So
163+
there's no need to uninstall your existing Deno extension.
158164

159165
Most changes and feature enhancements do not require changes to the extension
160166
though, as most information comes from the Deno Language Server itself, which is

package.json

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -502,7 +502,6 @@
502502
"test-compile": "tsc -b",
503503
"fmt": "deno fmt .vscode .github client/src media typescript-deno-plugin/src typescript-deno-plugin/*.md docs package.json tsconfig.json README.md CHANGELOG.md",
504504
"lint": "deno lint --unstable client/src typescript-deno-plugin/src docs",
505-
"watch": "tsc -b -w",
506505
"postinstall": "cd typescript-deno-plugin && npm i && cd ../client && npm i && cd .."
507506
},
508507
"dependencies": {

0 commit comments

Comments
 (0)