Bug#27447958 SCHEMA INCONSISTENCY AFTER CREATE DATABASE WITH LONG NAME

There is a limitation of 63 bytes for identifiers that can be distributed
in MySQL Cluster. The limitation is is caused by two columns in
ndb_schema table which are 63 bytes long. This is lower than the MySQL
limit and thus makes it impossible to distribute schema objects with
longer names.

Fix by changing the length of "db" and "name" column of ndb_schema table
to 255 bytes. Changing the schema of ndb_schema will cause a small
hickup when the binlog thread restart, but this is safe as the problem
of how to upgrade ndb_schema has been solved by WL#10162 which already
added another schema change in 8.0. The implementation of WL#10162 also
changed the code working with ndb_schema to dynamically adapt to the
table schema, thus it's mainly a matter of using a new higher limit when
the ndb_schema table is created.

Adapting ndb_ddl.identifier_limits test to the new increased limits,
asically changing it to test that long identifers now work. The legacy
63 bytes limit is still checked by the ndb_ddl.identifier_limits63_debug
test, making sure that code still works with non upgraded ndb_schema.

Change-Id: Ic10f7e9f6760fe6081a2cece00064b9b2f1466cd

Author: blaudden

mysql-test/suite/ndb_ddl/identifier_limits.result

@@ -5,19 +5,13 @@
 create table abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123(
 id int primary key
 ) engine=ndb;
-ERROR 42000: Identifier name 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' is too long
-show warnings;
-Level	Code	Message
-Warning	1296	[mysql.ndb_schema] Identifier length exceeds the 63 byte limit
-Error	1059	Identifier name 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' is too long
-Error	1031	Table storage engine for 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' doesn't have this option
+drop table abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
 # ############################################################
 # Bug19550973: CREATE/DROP DATABASE STATEMENT SEGFAULTS IF
 #              IDENTIFIER LENGTH IS >=64
 # ############################################################
 #
 # 1. Testing schema identifier with length 63
-# NOTE! ndb_schema identifier length limit is currently 63
 #
 CREATE DATABASE
 abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz12;
@@ -30,76 +24,52 @@ DROP TABLE abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz12.t1;
 DROP DATABASE abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz12;
 #
 # 2. Testing schema identifier with length 64
-# NOTE! MySQL Server allows 64, but ndb_schema limit is currently 63
 #
 CREATE DATABASE
 abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
-Warnings:
-Warning	1296	[mysql.ndb_schema] Identifier length exceeds the 63 byte limit
-Warning	1296	Identifier name 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' is too long
 # Verify database existence
 USE abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
 # Create non NDB table
 CREATE TABLE t1 (
 a int
 );
-# Create NDB table should fail
+# Create NDB table
 CREATE TABLE t2 (
 a int
 ) ENGINE=NDB;
-ERROR 42000: Identifier name 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' is too long
-show warnings;
-Level	Code	Message
-Warning	1296	[mysql.ndb_schema] Identifier length exceeds the 63 byte limit
-Error	1059	Identifier name 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' is too long
-Error	1031	Table storage engine for 't2' doesn't have this option
 #
-# 3. Databases with identifier length = 64 won't be replicated to other
-# MySQL Servers. Verify that the above created dabatase is not present
+# 3. Databases with identifier length = 64 is synchronized to other
+# MySQL Servers. Verify that the above created dabatase is present
 # in the other Server
+# NOTE! This testcase was fixed by BUG#27447958 which extended ndb_schema
+# to support identifiers > 63
 #
 USE abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
-ERROR 42000: Unknown database 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123'
 #
 # 4. Testing alter database
 #
 ALTER DATABASE
 abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123
 character set=utf8mb4;
-Warnings:
-Warning	1296	[mysql.ndb_schema] Identifier length exceeds the 63 byte limit
-Warning	1296	Identifier name 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' is too long
 CREATE DATABASE db1;
 CREATE TABLE db1.t1 (
 a int
 ) ENGINE=NDB;
+CREATE TABLE db1.t2 (
+a int
+) ENGINE=NDB;
 #
-# 4.1 Renaming table to too long database name should fail
+# 4.1 Renaming table to long database name
 #
 ALTER TABLE db1.t1
 RENAME abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123.t3;
-ERROR 42000: Identifier name 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' is too long
-SHOW WARNINGS;
-Level	Code	Message
-Warning	1296	[mysql.ndb_schema] Identifier length exceeds the 63 byte limit
-Error	1059	Identifier name 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' is too long
-Error	1025	Error on rename of './db1/t1' to './abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123/t3' (errno: 140 - Wrong create options)
 #
-# 4.2 Renaming table to too long table name should fail
+# 4.2 Renaming table to long table name
 #
-ALTER TABLE db1.t1
+ALTER TABLE db1.t2
 RENAME db1.abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
-ERROR 42000: Identifier name 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' is too long
-SHOW WARNINGS;
-Level	Code	Message
-Warning	1296	[mysql.ndb_schema] Identifier length exceeds the 63 byte limit
-Error	1059	Identifier name 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' is too long
-Error	1025	Error on rename of './db1/t1' to './db1/abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' (errno: 140 - Wrong create options)
 DROP DATABASE db1;
 DROP DATABASE abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
-Warnings:
-Warning	1296	[mysql.ndb_schema] Identifier length exceeds the 63 byte limit
-Warning	1296	Identifier name 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123' is too long
 # Checking that database doesn't exists
 USE abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
 ERROR 42000: Unknown database 'abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123'

mysql-test/suite/ndb_ddl/identifier_limits.test

@@ -9,12 +9,10 @@
 --echo # Bug11753491: MYSQLD CRASHES WHEN CREATING A CLUSTER TABLE WITH 64
 --echo #              CHARACTER TABLE NAME
 --echo # ####################################################################
---error ER_TOO_LONG_IDENT
 create table abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123(
   id int primary key
 ) engine=ndb;
-show warnings;
-
+drop table abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
 
 --echo # ############################################################
 --echo # Bug19550973: CREATE/DROP DATABASE STATEMENT SEGFAULTS IF
@@ -28,7 +26,6 @@ call mtr.add_suppression("Failed to distribute");
 
 --echo #
 --echo # 1. Testing schema identifier with length 63
---echo # NOTE! ndb_schema identifier length limit is currently 63
 --echo #
 CREATE DATABASE
   abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz12;
@@ -43,7 +40,6 @@ DROP DATABASE abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz12;
 
 --echo #
 --echo # 2. Testing schema identifier with length 64
---echo # NOTE! MySQL Server allows 64, but ndb_schema limit is currently 63
 --echo #
 CREATE DATABASE
   abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
@@ -54,20 +50,19 @@ USE abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
 CREATE TABLE t1 (
   a int
 );
---echo # Create NDB table should fail
---error ER_TOO_LONG_IDENT
+--echo # Create NDB table
 CREATE TABLE t2 (
   a int
 ) ENGINE=NDB;
-show warnings;
 
 --echo #
---echo # 3. Databases with identifier length = 64 won't be replicated to other
---echo # MySQL Servers. Verify that the above created dabatase is not present
+--echo # 3. Databases with identifier length = 64 is synchronized to other
+--echo # MySQL Servers. Verify that the above created dabatase is present
 --echo # in the other Server
+--echo # NOTE! This testcase was fixed by BUG#27447958 which extended ndb_schema
+--echo # to support identifiers > 63
 --echo #
 --connection mysqld2
---error ER_BAD_DB_ERROR
 USE abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
 --connection mysqld1
 
@@ -82,26 +77,21 @@ CREATE DATABASE db1;
 CREATE TABLE db1.t1 (
   a int
 ) ENGINE=NDB;
+CREATE TABLE db1.t2 (
+  a int
+) ENGINE=NDB;
 
 --echo #
---echo # 4.1 Renaming table to too long database name should fail
+--echo # 4.1 Renaming table to long database name
 --echo #
---error ER_TOO_LONG_IDENT
 ALTER TABLE db1.t1
   RENAME abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123.t3;
-# replace win slashes since not using default database
---replace_regex /[\\]/\//
-SHOW WARNINGS;
 
 --echo #
---echo # 4.2 Renaming table to too long table name should fail
+--echo # 4.2 Renaming table to long table name
 --echo #
---error ER_TOO_LONG_IDENT
-ALTER TABLE db1.t1
+ALTER TABLE db1.t2
   RENAME db1.abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;
-# replace win slashes since not using default database
---replace_regex /[\\]/\//
-SHOW WARNINGS;
 
 DROP DATABASE db1;
 DROP DATABASE abcdefghijklmnopqrstuvwxyz1234567890bcdefghijklmnopqrstuvwxyz123;

storage/ndb/plugin/ndb_schema_dist_table.cc

@@ -43,6 +43,14 @@ static const char *COL_EPOCH = "epoch";
 static const char *COL_TYPE = "type";
 static const char *COL_SCHEMA_OP_ID = "schema_op_id";
 
+// Length of the schema object identifiers which can be distributed by the
+// ndb_schema table. The legacy limit of 63 was increased in 8.0.18 to allow for
+// "any" identifier to be distributed. NOTE! Code still supports working with a
+// ndb_schema table using the legacy length, warning will be printed suggesting
+// upgrade
+static constexpr int IDENTIFIER_LENGTH = 255;
+static constexpr int LEGACY_IDENTIFIER_LENGTH = 63;
+
 Ndb_schema_dist_table::Ndb_schema_dist_table(Thd_ndb *thd_ndb)
     : Ndb_util_table(thd_ndb, DB_NAME, TABLE_NAME, true) {}
 
@@ -56,14 +64,14 @@ bool Ndb_schema_dist_table::check_schema() const {
   // backwards compatiblity reasons it's allowed to use such a schema
   // distribution table but not all identifiers will be possible to distribute.
   if (!(check_column_exist(COL_DB) && check_column_varbinary(COL_DB) &&
-        check_column_minlength(COL_DB, 63))) {
+        check_column_minlength(COL_DB, LEGACY_IDENTIFIER_LENGTH))) {
     return false;
   }
 
   // name
   // varbinary, at least 63 bytes long
   if (!(check_column_exist(COL_NAME) && check_column_varbinary(COL_NAME) &&
-        check_column_minlength(COL_NAME, 63))) {
+        check_column_minlength(COL_NAME, LEGACY_IDENTIFIER_LENGTH))) {
     return false;
   }
   // Check that db + name is the primary key, otherwise pk operations
@@ -206,21 +214,30 @@ bool Ndb_schema_dist_table::define_table_ndb(NdbDictionary::Table &new_table,
   // Allow table to be read+write also in single user mode
   new_table.setSingleUserMode(NdbDictionary::Table::SingleUserModeReadWrite);
 
+  // The length of "db" and "name" was adjusted in 8.0.18 to allow
+  // passing 255 bytes long identifiers
+  int db_and_name_length = IDENTIFIER_LENGTH;
+  if (mysql_version < 80018) {
+    // Use legacy identifier length when creating the table for
+    // backwards compatibility testing
+    db_and_name_length = LEGACY_IDENTIFIER_LENGTH;
+  }
+
   {
-    // db VARBINARY(63) NOT NULL
+    // db VARBINARY(255) NOT NULL
     NdbDictionary::Column col_db(COL_DB);
     col_db.setType(NdbDictionary::Column::Varbinary);
-    col_db.setLength(63);
+    col_db.setLength(db_and_name_length);
     col_db.setNullable(false);
     col_db.setPrimaryKey(true);
     if (!define_table_add_column(new_table, col_db)) return false;
   }
 
   {
-    // name VARBINARY(63) NOT NULL
+    // name VARBINARY(255) NOT NULL
     NdbDictionary::Column col_name(COL_NAME);
     col_name.setType(NdbDictionary::Column::Varbinary);
-    col_name.setLength(63);
+    col_name.setLength(db_and_name_length);
     col_name.setNullable(false);
     col_name.setPrimaryKey(true);
     if (!define_table_add_column(new_table, col_name)) return false;
@@ -304,6 +321,12 @@ bool Ndb_schema_dist_table::need_upgrade() const {
   if (!have_schema_op_id_column()) {
     return true;
   }
+  // The 'db' and 'name' column need to be upgrade if length is shorter than
+  // current identifier length
+  if (get_column_max_length(COL_DB) < IDENTIFIER_LENGTH ||
+      get_column_max_length(COL_NAME) < IDENTIFIER_LENGTH) {
+    return true;
+  }
   return false;
 }
 
@@ -321,9 +344,9 @@ bool Ndb_schema_dist_table::drop_events_in_NDB() const {
 std::string Ndb_schema_dist_table::define_table_dd() const {
   std::stringstream ss;
   ss << "CREATE TABLE " << db_name() << "." << table_name() << "(\n";
-  ss << "db VARBINARY(63) NOT NULL,"
-        "name VARBINARY(63) NOT NULL,"
-        "slock BINARY(32) NOT NULL,"
+  ss << "db VARBINARY(" << get_column_max_length(COL_DB) << ") NOT NULL,";
+  ss << "name VARBINARY(" << get_column_max_length(COL_NAME) << ") NOT NULL,";
+  ss << "slock BINARY(32) NOT NULL,"
         "query BLOB NOT NULL,"
         "node_id INT UNSIGNED NOT NULL,"
         "epoch BIGINT UNSIGNED NOT NULL,"