version 2.001002

Author: mauke

Changes

@@ -1,5 +1,21 @@
 Revision history for Function-Parameters
 
+2.001002  2017-11-09
+          - Fix crash when Function::Parameters is loaded at runtime by
+            multiple threads (a stack overflow due to infinite recursion).
+            This is arguably a core bug (#132413). The current workaround
+            employed by Function::Parameters slightly abuses an internal perl
+            mutex meant for something else (protecting op checkers), but it
+            fixes the issue on perls v5.16 .. v5.26.
+            v5.14 doesn't have this API yet, so the workaround is not thread
+            safe there. It is technically possible to still run into this issue
+            if two threads initialize Function::Parameters at the exact same
+            moment (I haven't managed to reproduce this yet, so hopefully it's
+            unlikely in practice).
+            It is possible to completely avoid the problem on all versions of
+            perl and Function::Parameters by making sure the module is loaded
+            before the first thread is created.
+
 2.001001  2017-07-12
           - fix duplicate type check on invocant:
                 method foo(T $self: $x) { ... }

MANIFEST

@@ -143,6 +143,7 @@ t/strict_3.fail
 t/strict_4.fail
 t/strict_5.fail
 t/threads.t
+t/threads2.t
 t/types_auto.t
 t/types_caller.t
 t/types_custom.t

lib/Function/Parameters.pm

@@ -13,7 +13,7 @@ sub _croak {
 
 use XSLoader;
 BEGIN {
-    our $VERSION = '2.001001';
+    our $VERSION = '2.001002';
     #$VERSION =~ s/-TRIAL[0-9]*\z//;
     XSLoader::load;
 }

lib/Function/Parameters/Info.pm

@@ -6,7 +6,7 @@ use warnings;
 use Function::Parameters;
 use Carp ();
 
-our $VERSION = '2.001001';
+our $VERSION = '2.001002';
 
 {
     package Function::Parameters::Param;