Resolve vulnerability with sass

Max · Max · commit 43420b19ec36 · 2022-09-05T13:02:57.000+02:00
diff --git a/MicroFrontendsIframe.code-workspace b/MicroFrontendsIframe.code-workspace
@@ -5,9 +5,18 @@
     }
   ],
   "settings": {
-    "eslint.autoFixOnSave": true,
     "editor.formatOnSave": true,
     "javascript.format.enable": false,
-    "eslint.alwaysShowStatus": true
+    "eslint.alwaysShowStatus": true,
+    "editor.codeActionsOnSave": {
+      "source.fixAll.eslint": true,
+      "source.fixAll.stylelint": true
+    },
+    "stylelint.validate": [
+      "css",
+      "less",
+      "postcss",
+      "scss"
+    ]
   }
-}
+}
diff --git a/README.md b/README.md
@@ -8,4 +8,4 @@ This libray implements micro-frontends with iframes and react components.
 
 ## Usage
 
-In the example folder there is an example of usage of this library.
+In the example folder there is an example of usage of this library (to test it run `npm i` and `npm start` from that folder).
diff --git a/example/child/package.json b/example/child/package.json
@@ -33,4 +33,4 @@
         "webpack-cli": "^3.3.4",
         "webpack-dev-server": "^3.7.1"
     }
-}
+}
diff --git a/example/child/src/App.jsx b/example/child/src/App.jsx
@@ -1,5 +1,4 @@
 import React from 'react';
-import './App.scss';
 import MicroIframe, { pluginInterceptor, isCalledByParent } from 'micro-frontend-iframe';
 
 MicroIframe.init('CHILD-ID');
diff --git a/example/child/src/App.scss b/example/child/src/App.scss
diff --git a/example/child/src/index.html b/example/child/src/index.html
@@ -7,7 +7,7 @@
     <meta name="viewport" content="width=device-width, initial-scale=1">
 </head>
 
-<body>
+<body style="background-color: aquamarine">
     <div id="root"></div>
 </body>
 
diff --git a/example/package.json b/example/package.json
@@ -31,12 +31,8 @@
         "babel-loader": "^8.0.6",
         "babel-preset-env": "^1.7.0",
         "concurrently": "^4.1.1",
-        "css-loader": "^3.1.0",
         "html-loader": "^0.5.5",
         "html-webpack-plugin": "^3.2.0",
-        "node-sass": "^4.12.0",
-        "sass-loader": "^7.1.0",
-        "style-loader": "^0.23.1",
         "webpack": "^4.34.0",
         "webpack-cli": "^3.3.4",
         "webpack-dev-server": "^3.7.1"
diff --git a/example/src/App.jsx b/example/src/App.jsx
@@ -23,11 +23,12 @@ class App extends React.Component {
     return (
       <React.Fragment>
         <h1>Micro-frontend-iframe Example!</h1>
+        <button type="button" onClick={this.sendToChild}>Send message to child</button>
+        <br/><br/>
         <IFrame
           src="http://localhost:8082"
           onReceiveMessage={this.receiveFromChild}
         />
-        <button type="button" onClick={this.sendToChild}>Send message to child</button>
         {messageFromChild && (
         <p>
           <b>Child says:</b>
diff --git a/example/webpack.config.js b/example/webpack.config.js
@@ -21,10 +21,6 @@ module.exports = {
           },
         },
       },
-      {
-        test: /\.scss$/,
-        use: ['style-loader', 'css-loader', 'sass-loader'],
-      },
       {
         test: /\.html$/,
         use: [

Original file line number	Diff line number	Diff line change
`@@ -8,4 +8,4 @@ This libray implements micro-frontends with iframes and react components.`
`8`	`8`
`9`	`9`	`## Usage`
`10`	`10`
`11`		`-In the example folder there is an example of usage of this library.`
	`11`	+In the example folder there is an example of usage of this library (to test it run `npm i` and `npm start` from that folder).
Original file line number	Diff line number	Diff line change
`@@ -33,4 +33,4 @@`
`33`	`33`	`"webpack-cli": "^3.3.4",`
`34`	`34`	`"webpack-dev-server": "^3.7.1"`
`35`	`35`	`}`
`36`		`-}`
	`36`	`+}`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,4 @@`
`1`	`1`	`import React from 'react';`
`2`		`-import './App.scss';`
`3`	`2`	`import MicroIframe, { pluginInterceptor, isCalledByParent } from 'micro-frontend-iframe';`
`4`	`3`
`5`	`4`	`MicroIframe.init('CHILD-ID');`