Skip to content

Commit 144633c

Browse files
committed
💚 [open-api-framework#188] fix dump data ci tests
1 parent 8375cf1 commit 144633c

File tree

2 files changed

+3
-6
lines changed

2 files changed

+3
-6
lines changed

.github/workflows/bin-check.yml

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ jobs:
3939
python src/manage.py migrate
4040
src/manage.py loaddata demodata
4141
SCRIPTPATH=bin DUMP_FILE=dump.sql bin/dump_data.sh --combined
42+
mkdir csv_exports
43+
SCRIPTPATH=bin DUMP_FILE=dump.sql bin/dump_data.sh --csv
4244
env:
4345
DB_PASSWORD: ""
4446
DB_USER: postgres
@@ -57,11 +59,6 @@ jobs:
5759
createdb -h localhost -U postgres test
5860
psql -v ON_ERROR_STOP=1 -h localhost -U postgres -d test -f dump.sql
5961
60-
- name: dump data to csv
61-
run: |
62-
mkdir csv_exports
63-
SCRIPTPATH=bin DUMP_FILE=dump.sql bin/dump_data.sh --csv
64-
6562
- name: validate csv dump
6663
run: |
6764
test -f csv_exports/core_object.csv || exit 1

bin/dump_data.sh

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
# The schema dump could not use -t to filter tables because this excludes extensions like postgis in the dump.
1212
# pg_dump also does not add related tables automatically, so `dump_data.sh` does not add related data from accounts to the dump.
1313
#
14-
# with --csv and csv dump can be created for all tables in the given components. The csv files will be generated in CSV_OUTPUT_DIR (csv_exports by default).
14+
# with --csv a csv dump can be created for all tables in the given components. The csv files will be generated in CSV_OUTPUT_DIR (csv_exports by default).
1515

1616
set -e
1717

0 commit comments

Comments
 (0)