forked from VNG-Realisatie/vng-api-common
-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Closed
Copy link
Labels
Description
This was noticed via maykinmedia/open-klant#525
It seems that exceptions that lead to 500 errors via the API are not sent to Sentry, which makes debugging more difficult. I tested this locally and this issue does not seem to occur if DEBUG=True
Possibly related line:
| sentry_client.captureException() |
I think that this silenced importerror is the culprit: https://github.com/maykinmedia/commonground-api-common/blob/main/vng_api_common/compat.py#L7
TODO:
- ensure the proper sentry client is imported
- remove need for try-except block around the import, because this obfuscates issues like this
- add tests to verify that errors are sent to Sentry
- make a patch release of this library
- upgrade this library in all components that use this exception handler
- Open Zaak ⬆️ [maykinmedia/commonground-api-common#134] Upgrade commongr… open-zaak/open-zaak#2242
- Open Notificaties ⬆️ [maykinmedia/commonground-api-common#134] Upgrade commonground-api… open-zaak/open-notificaties#341
- Open Klant ⬆️ [maykinmedia/commonground-api-common#134] Upgrade commonground-api… open-klant#537
- Objects API (should be fixed in its own exception_handler) 🐛 [maykinmedia/commonground-api-common#134] sentry issue objects-api#701
- Objecttypen API (should be fixed in its own exception_handler) 🐛 [maykinmedia/commonground-api-common#134] Ensure exception handler … objecttypes-api#216
- Open Product (should be fixed in its own exception_handler) 🐛 [maykinmedia/commonground-api-common#134] Ensure exception handler … open-product#241
- Referentielijsten ⬆️ [maykinmedia/commonground-api-common#134] Upgrade commonground-api-common to ensure API errors are sent to Sentry referentielijsten#114
- Open Organisatie ⬆️ [maykinmedia/commonground-api-common#134] Upgrade commonground-api… open-organisatie#90
Metadata
Metadata
Assignees
Labels
Type
Projects
Status
Done