Merge pull request #102 from AlexWayfer/remove_ruby_warnings

Remove warnings from Ruby (MRI)

Author: mdub

.rspec

@@ -1 +1,2 @@
 --color
+--warnings

lib/clamp/attribute/definition.rb

@@ -54,11 +54,11 @@ def multivalued?
       end
 
       def required?
-        @required
+        @required ||= false
       end
 
       def hidden?
-        @hidden
+        @hidden ||= false
       end
 
       def attribute_name

lib/clamp/messages.rb

@@ -11,7 +11,10 @@ def messages=(new_messages)
     end
 
     def message(key, options = {})
-      format(messages.fetch(key), options)
+      string = messages.fetch(key)
+      return string if options.empty?
+
+      format string, options
     end
 
     def clear_messages!

lib/clamp/option/declaration.rb

@@ -29,7 +29,7 @@ def declared_options
       end
 
       def recognised_options
-        unless @implicit_options_declared
+        unless @implicit_options_declared ||= false
           declare_implicit_help_option
           @implicit_options_declared = true
         end

lib/clamp/subcommand/declaration.rb

@@ -47,7 +47,7 @@ def default_subcommand=(name)
 
       def default_subcommand(*args, &block)
         if args.empty?
-          @default_subcommand
+          @default_subcommand ||= false
         else
           $stderr.puts "WARNING: Clamp default_subcommand syntax has changed; check the README."
           $stderr.puts "  (from #{caller(1..1).first})"
@@ -59,10 +59,10 @@ def default_subcommand(*args, &block)
       private
 
       def declare_subcommand_parameters
-        if @default_subcommand
+        if default_subcommand
           parameter "[SUBCOMMAND]", "subcommand",
                     attribute_name: :subcommand_name,
-                    default: @default_subcommand,
+                    default: default_subcommand,
                     inheritable: false
         else
           parameter "SUBCOMMAND", "subcommand",

lib/clamp/subcommand/definition.rb

@@ -3,16 +3,13 @@
 module Clamp
   module Subcommand
 
-    Definition = Struct.new(:name, :description, :subcommand_class) do
+    Definition = Struct.new(:names, :description, :subcommand_class) do
 
       def initialize(names, description, subcommand_class)
-        @names = Array(names)
-        @description = description
-        @subcommand_class = subcommand_class
+        names = Array(names)
+        super
       end
 
-      attr_reader :names, :description, :subcommand_class
-
       def is_called?(name)
         names.member?(name)
       end