fix: Sanitize entity type labels in graph memory Cypher queries #3783
+407
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where entity types with special characters (e.g., "Person-Name", "City/State", "Entity@Type#123") would cause Cypher query syntax errors when used as node labels in Neo4j graph database queries.
Changes:
sanitizeLabelfunction to replace special characters with underscoresImplementation:
_addEntitiesmethod ingraph_memory.tsto sanitizesourceTypeanddestinationTypebefore using them in Cypher queries/[^A-Za-z0-9_]/gto replace invalid characters with underscoresFixes a similar issue #3020 that was fixed in the python implementation
Type of change
How Has This Been Tested?
Added comprehensive unit tests in
graph_memory.test.tscovering:Test Configuration:
To reproduce:
cd mem0-ts npm run test:ts -- graph_memory.test.tsChecklist:
Maintainer Checklist