Unknown checksum algorithms (based on length) are errors

Author: jasonkarns

bin/ruby-build

@@ -247,7 +247,7 @@ compute_md5() {
 }
 
 verify_checksum() {
-  local checksum_command="compute_sha2"
+  local checksum_command
 
   # If the specified filename doesn't exist, return success
   local filename="$1"
@@ -266,6 +266,9 @@ verify_checksum() {
     [ -n "$HAS_SHA2_SUPPORT" ] || return 0
     checksum_command="compute_sha2"
     ;;
+  *) # unknown checksum algorithm, return failure
+    return 1
+    ;;
   esac
 
   # If the computed checksum is empty, return failure

test/fixtures/definitions/with-invalid-checksum

@@ -1 +1 @@
-install_package "package-1.0.0" "http://example.com/packages/package-1.0.0.tar.gz#invalid" copy
+install_package "package-1.0.0" "http://example.com/packages/package-1.0.0.tar.gz#invalid_64_character_checksum_0000000000000000000000000000000000" copy