CP-17268 move bisect setup code into a module of its own

We need this code for the other binaries in this repo, too. Hence, it
better lives in its own module

Signed-off-by: Christian Lindig <[email protected]>

Author: lindig

lib/bisect_setup.ml

@@ -0,0 +1,29 @@
+(** set up the BISECT_FILE env var to point to a temp directory where
+ *  the log files go
+ *)
+
+module D = Debug.Make(struct let name = "bisect_setup" end)
+
+let init name =
+  let (//) = Filename.concat in
+  let tmpdir =
+    let getenv n   = try Sys.getenv n with Not_found -> "" in
+    let dirs    = 
+      [ getenv "TMP"
+      ; getenv "TEMP"
+      ; "/tmp"
+      ; "/usr/tmp"
+      ; "/var/tmp"
+      ] in
+    let is_dir  = function 
+    | ""    -> false
+    | path  -> try Sys.is_directory path with Sys_error _ -> false
+    in try
+      List.find is_dir dirs
+    with
+      Not_found -> D.error "can't find temp directory %s" __LOC__; exit 1
+  in try 
+    ignore (Sys.getenv "BISECT_FILE") 
+  with Not_found ->
+    Unix.putenv "BISECT_FILE" (tmpdir // Printf.sprintf "bisect-%s" name)
+ 

lib/xenopsd.ml

@@ -120,32 +120,7 @@ let configure ?(specific_options=[]) ?(specific_essential_paths=[]) ?(specific_n
 		error "%s" m;
 		exit 1
 
-(** set up the BISECT_FILE env var to point to a temp directory where
- *  the log files go
- *)
-let setup_bisect name =
-  let (//) = Filename.concat in
-  let tmpdir =
-    let getenv n   = try Sys.getenv n with Not_found -> "" in
-    let dirs    = 
-      [ getenv "TMP"
-      ; getenv "TEMP"
-      ; "/tmp"
-      ; "/usr/tmp"
-      ; "/var/tmp"
-      ] in
-    let is_dir  = function 
-    | ""    -> false
-    | path  -> try Sys.is_directory path with Sys_error _ -> false
-    in try
-      List.find is_dir dirs
-    with
-      Not_found -> error "can't find temp directory %s" __LOC__; exit 1
-  in try 
-    ignore (Sys.getenv "BISECT_FILE") 
-  with Not_found ->
-    Unix.putenv "BISECT_FILE" (tmpdir // Printf.sprintf "bisect-%s" name)
- 
+
 let main backend =
 	Printexc.record_backtrace true;
 
@@ -174,7 +149,7 @@ let main backend =
 	Sys.set_signal Sys.sigpipe Sys.Signal_ignore;
   Sys.set_signal Sys.sigterm (Sys.Signal_handle signal_handler);
 
-  setup_bisect name; (* set up coverage profiling *)
+  Bisect_setup.init name; (* set up coverage profiling *)
 
 	Xenops_utils.set_fs_backend
 		(Some (if !persist