Skip to content

Commit 72b173d

Browse files
committed
fix bug. The StorageClass is not correct in ListObjectsResult/ListObjectVersionsResult.
1 parent ed5cb9f commit 72b173d

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

sdk/src/model/ListObjectVersionsResult.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ ListObjectVersionsResult& ListObjectVersionsResult::operator =(const std::string
127127
if (node && node->GetText()) content.size_ = std::atoll(node->GetText());
128128

129129
node = contents_node->FirstChildElement("StorageClass");
130-
if (node && node->GetText()) content.storageClass_ = ToStorageClassType(node->GetText());
130+
if (node && node->GetText()) content.storageClass_ = node->GetText();
131131

132132
node = contents_node->FirstChildElement("Type");
133133
if (node && node->GetText()) content.type_ = node->GetText();

sdk/src/model/ListObjectsResult.cc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -112,7 +112,7 @@ ListObjectsResult& ListObjectsResult::operator =(const std::string& result)
112112
if (node && node->GetText()) content.size_ = std::atoll(node->GetText());
113113

114114
node = contents_node->FirstChildElement("StorageClass");
115-
if (node && node->GetText()) content.storageClass_ = ToStorageClassType(node->GetText());
115+
if (node && node->GetText()) content.storageClass_ = node->GetText();
116116

117117
node = contents_node->FirstChildElement("Type");
118118
if (node && node->GetText()) content.type_ = node->GetText();

test/src/Object/ObjectBasicOperationTest.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -132,6 +132,7 @@ TEST_F(ObjectBasicOperationTest, ListAllObjectsTest)
132132
int i = 0;
133133
for (auto const &obj : listOutcome.result().ObjectSummarys()) {
134134
EXPECT_EQ(obj.Size(), 100LL);
135+
EXPECT_EQ(obj.StorageClass(), "Standard");
135136
i++;
136137
}
137138
EXPECT_EQ(i, 20);
@@ -1122,7 +1123,7 @@ TEST_F(ObjectBasicOperationTest, ListObjectsResult)
11221123
<ETag>&quot;5B3C1A2E053D763E1B002CC607C5A0FE&quot;</ETag>
11231124
<Type>Normal</Type>
11241125
<Size>344606</Size>
1125-
<StorageClass>Standard</StorageClass>
1126+
<StorageClass>IA</StorageClass>
11261127
<Owner>
11271128
<ID>00220120222</ID>
11281129
<DisplayName>user-example</DisplayName>
@@ -1157,6 +1158,8 @@ TEST_F(ObjectBasicOperationTest, ListObjectsResult)
11571158
EXPECT_EQ(result.ObjectSummarys().size(), 4UL);
11581159
EXPECT_EQ(result.ObjectSummarys()[0].ETag(), "5B3C1A2E053D763E1B002CC607C5A0FE");
11591160
EXPECT_EQ(result.ObjectSummarys()[0].Size(), 5368709120LL);
1161+
EXPECT_EQ(result.ObjectSummarys()[0].StorageClass(), "Standard");
1162+
EXPECT_EQ(result.ObjectSummarys()[1].StorageClass(), "IA");
11601163
}
11611164

11621165
TEST_F(ObjectBasicOperationTest, ListObjectsResultWithEncodingType)

test/src/Object/ObjectVersioningTest.cc

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1722,6 +1722,7 @@ TEST_F(ObjectVersioningTest, ListObjectVersionsResultTest)
17221722
</ListVersionsResult>
17231723
)";
17241724
auto result = ListObjectVersionsResult(std::make_shared<std::stringstream>(xml));
1725+
EXPECT_EQ(result.ObjectVersionSummarys()[0].StorageClass(), "Standard");
17251726

17261727
xml = R"(
17271728
<?xml version="1.0" encoding="UTF-8"?>

0 commit comments

Comments
 (0)