Shapeless compilation failed on Ubuntu 24.04

[zcbenz]

When testing the Ubuntu 24.04 runner of GitHub Actions some of the compile tests failed on it:

  1) compile
       shapelessMean:
     AssertionError: expected [ false ] to not include false
      at <anonymous> (tests/utils.ts:15:76)
      at assertArray (tests/utils.ts:8:5)
      at assertArrayAllTrue (tests/utils.ts:15:42)
      at Context.<anonymous> (tests/compile.spec.ts:563:5)

  2) compile
       compileShapelessWithBroadcast:
     Error: [broadcast_shapes] Shapes (2,2,5) and (2,3,2,5) cannot be broadcast.
      at Context.<anonymous> (tests/compile.spec.ts:807:13)

I'm not sure if it is a bug in JS bindings or in upstream code, but can you consider updating this repo's CI to run on Ubuntu 24.04 to help root out some possibilities?

[awni]

That's odd. The latest base Docker images on CircleCI are for Ubuntu 22 https://circleci.com/developer/images/image/cimg/base

I do see a "machine image" for Ubuntu 24 which we could try to test on as a one-off thing but we wouldn't use it for regular CI.

[zcbenz]

Hmm I will get a local Ubuntu 24 to test, it is time to update my other projects anyway.

[awni]

I got an action running on a fork to test Ubuntu 24: awni#1

I'll see if the tests pass there and get back to you.

[awni]

Indeed, I did get the same errors as you:

======================================================================
ERROR: test_compile_shapeless_with_broadcast (test_compile.TestCompile)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/mlx/mlx/python/tests/test_compile.py", line 920, in test_compile_shapeless_with_b
    out = cfun((a, b))
ValueError: [broadcast_shapes] Shapes (2,2,5) and (2,3,2,5) cannot be broadcast.

======================================================================
FAIL: test_shapeless_mean (test_compile.TestCompile)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/mlx/mlx/python/tests/test_compile.py", line 686, in test_shapeless_mean
    self.assertTrue(mx.allclose(out, mean(x)))
AssertionError: array(False, dtype=bool) is not true

----------------------------------------------------------------------
Ran 512 tests in 49.678s

FAILED (failures=1, errors=1, skipped=27)

I will investigate what's going on there.

[awni]

It seems like the problem is using a vector<bool> here. For some reason that stack is not getting cleared properly. If I switch it to a regular vector type it works fine.. which makes me wonder if there is a bug in the std::vector<bool> implementation.