fix(compiler): do not autoinclude components declared as entry points (angular#10898)

Author: vsavkin

modules/@angular/compiler/src/metadata_resolver.ts

@@ -388,11 +388,8 @@ export class CompileMetadataResolver {
     });
     moduleMeta.entryComponents.forEach((entryComponentType) => {
       if (!moduleMeta.transitiveModule.directivesSet.has(entryComponentType.runtime)) {
-        this._addDirectiveToModule(
-            this.getDirectiveMetadata(entryComponentType.runtime), moduleMeta.type.runtime,
-            moduleMeta.transitiveModule, moduleMeta.declaredDirectives);
-        this._console.warn(
-            `NgModule ${stringify(moduleMeta.type.runtime)} uses ${stringify(entryComponentType.runtime)} via "entryComponents" but it was neither declared nor imported! This warning will become an error after final.`);
+        throw new BaseException(
+            `NgModule ${stringify(moduleMeta.type.runtime)} uses ${stringify(entryComponentType.runtime)} via "entryComponents" but it was neither declared nor imported! If ${stringify(entryComponentType.runtime)} is declared in an imported module, make sure it is exported.`);
       }
     });
     // Collect @Component.directives/pipes/entryComponents into our declared

modules/@angular/core/test/linker/ng_module_integration_spec.ts

@@ -263,27 +263,19 @@ function declareTests({useJit}: {useJit: boolean}) {
             .toBe(SomeComp);
       });
 
-      it('should warn and auto declare when using an entryComponent that was neither declared nor imported',
-         () => {
-           @Component({template: '', entryComponents: [SomeComp]})
-           class SomeCompWithEntryComponents {
-           }
-
-           @NgModule({entryComponents: [SomeCompWithEntryComponents]})
-           class SomeModule {
-           }
+      it('should throw when using an entryComponent that was neither declared nor imported', () => {
+        @Component({template: '', entryComponents: [SomeComp]})
+        class SomeCompWithEntryComponents {
+        }
 
-           const ngModule = createModule(SomeModule);
-           expect(ngModule.componentFactoryResolver
-                      .resolveComponentFactory(SomeCompWithEntryComponents)
-                      .componentType)
-               .toBe(SomeCompWithEntryComponents);
+        @NgModule({entryComponents: [SomeCompWithEntryComponents]})
+        class SomeModule {
+        }
 
-           expect(console.warnings).toEqual([
-             `NgModule ${stringify(SomeModule)} uses ${stringify(SomeCompWithEntryComponents)} via "entryComponents" but it was neither declared nor imported! This warning will become an error after final.`,
-             `Component ${stringify(SomeCompWithEntryComponents)} in NgModule ${stringify(SomeModule)} uses ${stringify(SomeComp)} via "entryComponents" but it was neither declared nor imported into the module! This warning will become an error after final.`
-           ]);
-         });
+        expect(() => createModule(SomeModule))
+            .toThrowError(
+                `NgModule ${stringify(SomeModule)} uses ${stringify(SomeCompWithEntryComponents)} via "entryComponents" but it was neither declared nor imported! If ${stringify(SomeCompWithEntryComponents)} is declared in an imported module, make sure it is exported.`);
+      });
 
       it('should create ComponentFactories via ANALYZE_FOR_ENTRY_COMPONENTS', () => {
         @NgModule({

modules/@angular/platform-server/test/integration_spec.ts

@@ -24,7 +24,7 @@ function writeBody(html: string): any {
 class MyServerApp {
 }
 
-@NgModule({imports: [ServerModule], bootstrap: [MyServerApp]})
+@NgModule({imports: [ServerModule], declarations: [MyServerApp], bootstrap: [MyServerApp]})
 class ExampleModule {
 }
 

modules/playground/src/animate/index.ts

@@ -11,7 +11,7 @@ import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
 
 import {AnimateApp} from './app/animate-app';
 
-@NgModule({bootstrap: [AnimateApp], imports: [BrowserModule]})
+@NgModule({declarations: [AnimateApp], bootstrap: [AnimateApp], imports: [BrowserModule]})
 class ExampleModule {
 }
 

modules/playground/src/async/index.ts

@@ -98,7 +98,8 @@ class AsyncApplication {
   };
 }
 
-@NgModule({bootstrap: [AsyncApplication], imports: [BrowserModule]})
+@NgModule(
+    {declarations: [AsyncApplication], bootstrap: [AsyncApplication], imports: [BrowserModule]})
 class ExampleModule {
 }
 

modules/playground/src/gestures/index.ts

@@ -25,7 +25,7 @@ class GesturesCmp {
   onRotate(event: any /** TODO #9100 */): void { this.rotateAngle = event.rotation; }
 }
 
-@NgModule({bootstrap: [GesturesCmp], imports: [BrowserModule]})
+@NgModule({declarations: [GesturesCmp], bootstrap: [GesturesCmp], imports: [BrowserModule]})
 class ExampleModule {
 }
 

modules/playground/src/hello_world/index.ts

@@ -57,6 +57,6 @@ export class HelloCmp {
   changeGreeting(): void { this.greeting = 'howdy'; }
 }
 
-@NgModule({bootstrap: [HelloCmp], declarations: [RedDec], imports: [BrowserModule]})
+@NgModule({bootstrap: [HelloCmp], declarations: [HelloCmp, RedDec], imports: [BrowserModule]})
 class ExampleModule {
 }

modules/playground/src/http/index.ts

@@ -13,7 +13,7 @@ import {platformBrowserDynamic} from '@angular/platform-browser-dynamic';
 
 import {HttpCmp} from './app/http_comp';
 
-@NgModule({bootstrap: [HttpCmp], imports: [BrowserModule, HttpModule]})
+@NgModule({declarations: [HttpCmp], bootstrap: [HttpCmp], imports: [BrowserModule, HttpModule]})
 class ExampleModule {
 }
 

modules/playground/src/key_events/index.ts

@@ -41,7 +41,7 @@ class KeyEventsApp {
   resetShiftEnter(): void { this.shiftEnter = false; }
 }
 
-@NgModule({bootstrap: [KeyEventsApp], imports: [BrowserModule]})
+@NgModule({declarations: [KeyEventsApp], bootstrap: [KeyEventsApp], imports: [BrowserModule]})
 class ExampleModule {
 }
 

modules/playground/src/model_driven_forms/index.ts

@@ -158,7 +158,7 @@ class ReactiveForms {
 
 @NgModule({
   bootstrap: [ReactiveForms],
-  declarations: [ShowError],
+  declarations: [ReactiveForms, ShowError],
   imports: [BrowserModule, ReactiveFormsModule]
 })
 class ExampleModule {