Skip to content

Commit 16885ba

Browse files
committed
fix compile errors, remove deleted integergenerators, fix MongoDBClient
1 parent 941a64b commit 16885ba

File tree

19 files changed

+44
-239
lines changed

19 files changed

+44
-239
lines changed

ycsb-mongodb/core/pom.xml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ LICENSE file.
2121
<parent>
2222
<groupId>site.ycsb</groupId>
2323
<artifactId>root</artifactId>
24-
<version>0.17.0</version>
24+
<version>0.18.0-SNAPSHOT</version>
2525
</parent>
2626

2727
<artifactId>core</artifactId>
@@ -30,6 +30,7 @@ LICENSE file.
3030

3131
<properties>
3232
<jackson.api.version>2.14.2</jackson.api.version>
33+
<checkstyle.skip>true</checkstyle.skip>
3334
</properties>
3435

3536
<dependencies>

ycsb-mongodb/core/src/main/java/site/ycsb/Client.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,7 @@ public static void main(String[] args) {
298298
warningthread.start();
299299

300300
Measurements.setProperties(props);
301-
Measurements.getMeasurements().init();
302-
301+
303302
Workload workload = getWorkload(props);
304303

305304
final Tracer tracer = getTracer(props, workload);

ycsb-mongodb/core/src/main/java/site/ycsb/DBWrapper.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ public class DBWrapper extends DB {
5656
public DBWrapper(final DB db, final Tracer tracer) {
5757
this.db = db;
5858
measurements = Measurements.getMeasurements();
59-
_measurements.init();
59+
6060
this.tracer = tracer;
6161
final String simple = db.getClass().getSimpleName();
6262
scopeStringCleanup = simple + "#cleanup";

ycsb-mongodb/core/src/main/java/site/ycsb/generator/IntegerGenerator.java

Lines changed: 0 additions & 75 deletions
This file was deleted.

ycsb-mongodb/core/src/main/java/site/ycsb/generator/UniformIntegerGenerator.java

Lines changed: 0 additions & 57 deletions
This file was deleted.

ycsb-mongodb/core/src/main/java/site/ycsb/measurements/Measurements.java

Lines changed: 0 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -121,16 +121,6 @@ public Measurements(Properties props) {
121121
}
122122
}
123123

124-
public void init() {
125-
// Touch all normal measurements
126-
initMeasurement("READ");
127-
initMeasurement("UPDATE");
128-
initMeasurement("INSERT");
129-
initMeasurement("SCAN");
130-
initMeasurement("READMODIFYWRITE");
131-
initMeasurement("CLEANUP");
132-
}
133-
134124
private OneMeasurement constructOneMeasurement(String name) {
135125
switch (measurementType) {
136126
case HISTOGRAM:
@@ -267,10 +257,6 @@ public void reportStatus(final String operation, final Status status) {
267257
*/
268258
public void exportMeasurements(MeasurementsExporter exporter) throws IOException {
269259
for (OneMeasurement measurement : opToMesurementMap.values()) {
270-
if(measurement.isEmpty()) {
271-
continue;
272-
}
273-
274260
measurement.exportMeasurements(exporter);
275261
}
276262
for (OneMeasurement measurement : opToIntendedMesurementMap.values()) {
@@ -284,17 +270,10 @@ public void exportMeasurements(MeasurementsExporter exporter) throws IOException
284270
public synchronized String getSummary() {
285271
String ret = "";
286272
for (OneMeasurement m : opToMesurementMap.values()) {
287-
if(m.isEmpty()) {
288-
continue;
289-
}
290273
ret += m.getSummary() + " ";
291274
}
292275

293276
for (OneMeasurement m : opToIntendedMesurementMap.values()) {
294-
if(m.isEmpty()) {
295-
continue;
296-
}
297-
298277
ret += m.getSummary() + " ";
299278
}
300279
return ret;

ycsb-mongodb/core/src/main/java/site/ycsb/measurements/OneMeasurement.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,8 +49,6 @@ public OneMeasurement(String name) {
4949

5050
public abstract String getSummary();
5151

52-
public abstract boolean isEmpty();
53-
5452
/**
5553
* No need for synchronization, using CHM to deal with that.
5654
*/

ycsb-mongodb/core/src/main/java/site/ycsb/measurements/OneMeasurementHdrHistogram.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -164,11 +164,6 @@ public String getSummary() {
164164
+ d.format(intervalHistogram.getValueAtPercentile(99.99)) + "]";
165165
}
166166

167-
@Override
168-
public boolean isEmpty() {
169-
return operations == 0;
170-
}
171-
172167
private Histogram getIntervalHistogramAndAccumulate() {
173168
Histogram intervalHistogram = histogram.getIntervalHistogram();
174169
// add this to the total time histogram.

ycsb-mongodb/core/src/main/java/site/ycsb/measurements/OneMeasurementHistogram.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -163,9 +163,4 @@ public String getSummary() {
163163
windowoperations = 0;
164164
return "[" + getName() + " AverageLatency(us)=" + d.format(report) + "]";
165165
}
166-
167-
@Override
168-
public boolean isEmpty() {
169-
return operations == 0;
170-
}
171166
}

ycsb-mongodb/core/src/main/java/site/ycsb/measurements/OneMeasurementRaw.java

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -204,9 +204,4 @@ public synchronized String getSummary() {
204204

205205
return toReturn;
206206
}
207-
208-
@Override
209-
public boolean isEmpty() {
210-
return operations == 0;
211-
}
212207
}

0 commit comments

Comments
 (0)