Skip to content

Commit 3f72c9e

Browse files
author
Ryan Baxter
committed
1 parent 6d0d094 commit 3f72c9e

File tree

4 files changed

+52
-24
lines changed

4 files changed

+52
-24
lines changed

feign-hystrix/src/main/java/demo/FeignClientApplication.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
public class FeignClientApplication {
1717

1818
@Bean
19-
public ApplicationRunner runner(final RestClient client) {
19+
public ApplicationRunner runner(final UrlRestClient client) {
2020
return new ApplicationRunner() {
2121

2222
@Override
@@ -32,13 +32,13 @@ public static void main(String[] args) {
3232
}
3333

3434
@FeignClient(name = "example", url = "example.com", fallback=FallbackClient.class)
35-
interface RestClient {
35+
interface UrlRestClient {
3636
@RequestMapping(value="/", method = RequestMethod.GET)
3737
String hello();
3838
}
3939

4040
@Component
41-
class FallbackClient implements RestClient {
41+
class FallbackClient implements UrlRestClient {
4242
@Override
4343
public String hello() {
4444
return "oops";

feign-hystrix/src/test/java/demo/AdhocTestSuite.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,6 @@
2121
import org.junit.runners.Suite;
2222
import org.junit.runners.Suite.SuiteClasses;
2323

24-
import test.FeignClientWithServerListApplicationTests;
25-
2624
/**
2725
* A test suite for probing weird ordering problems in the tests.
2826
*

feign-hystrix/src/test/java/demo/FeignClientApplicationTests.java

Lines changed: 32 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,51 @@
11
package demo;
22

3-
import static org.junit.Assert.assertTrue;
4-
3+
import demo.FeignClientApplicationTests.TestApplication;
54
import org.junit.Test;
65
import org.junit.runner.RunWith;
76
import org.springframework.beans.factory.annotation.Autowired;
7+
import org.springframework.boot.SpringApplication;
8+
import org.springframework.boot.autoconfigure.EnableAutoConfiguration;
89
import org.springframework.boot.test.SpringApplicationConfiguration;
910
import org.springframework.boot.test.WebIntegrationTest;
11+
import org.springframework.cloud.netflix.feign.EnableFeignClients;
12+
import org.springframework.context.annotation.Bean;
13+
import org.springframework.context.annotation.Configuration;
1014
import org.springframework.test.annotation.DirtiesContext;
1115
import org.springframework.test.context.junit4.SpringJUnit4ClassRunner;
16+
import demo.FeignClientWithServerListApplicationTests.FallbackRestClient;
17+
18+
import static org.junit.Assert.assertTrue;
19+
1220

1321
@RunWith(SpringJUnit4ClassRunner.class)
14-
@SpringApplicationConfiguration(classes = FeignClientApplication.class)
22+
@SpringApplicationConfiguration(classes = TestApplication.class)
1523
@WebIntegrationTest(randomPort = true)
1624
@DirtiesContext
1725
public class FeignClientApplicationTests {
1826

1927
@Autowired
20-
private RestClient client;
28+
private UrlRestClient client;
29+
30+
@Configuration
31+
@EnableAutoConfiguration
32+
@EnableFeignClients
33+
protected static class TestApplication {
34+
35+
@Bean
36+
public FallbackClient fallback() {
37+
return new FallbackClient();
38+
}
39+
40+
@Bean
41+
public FallbackRestClient fallbackRestClient() {
42+
return new FallbackRestClient();
43+
}
44+
45+
public static void main(String[] args) {
46+
SpringApplication.run(FeignClientApplication.class, args);
47+
}
48+
}
2149

2250
@Test
2351
public void clientConnects() {

feign-hystrix/src/test/java/test/FeignClientWithServerListApplicationTests.java renamed to feign-hystrix/src/test/java/demo/FeignClientWithServerListApplicationTests.java

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1-
package test;
1+
package demo;
22

3+
import demo.FeignClientWithServerListApplicationTests.TestApplication;
34
import org.junit.Test;
45
import org.junit.runner.RunWith;
56
import org.springframework.beans.factory.annotation.Autowired;
@@ -16,22 +17,18 @@
1617
import org.springframework.web.bind.annotation.RequestMapping;
1718
import org.springframework.web.bind.annotation.RequestMethod;
1819

19-
import test.FeignClientWithServerListApplicationTests.TestApplication;
20-
2120
import static org.junit.Assert.assertTrue;
2221

2322
@RunWith(SpringJUnit4ClassRunner.class)
2423
@SpringApplicationConfiguration(classes = TestApplication.class)
25-
// Increase hystrix timeout or else requests timeout on CI server
26-
@WebIntegrationTest(randomPort = true, value = {
27-
"myexample.ribbon.listOfServers:example.com",
28-
"hystrix.command.default.execution.isolation.thread.timeoutInMilliseconds: 60000" })
24+
//Increase hystrix timeout or else requests timeout on CI server
25+
@WebIntegrationTest(randomPort = true, value = {"myexample.ribbon.listOfServers:example.com", "hystrix.command.default.execution.isolation.thread.timeoutInMilliseconds: 60000"})
2926
@DirtiesContext
3027
public class FeignClientWithServerListApplicationTests {
3128

3229
@Autowired
33-
private RestClient client;
34-
30+
private ServiceRestClient client;
31+
3532
@Test
3633
public void clientConnects() {
3734
assertTrue(client.hello().contains("<html"));
@@ -47,23 +44,28 @@ public FallbackRestClient fallbackRestClient() {
4744
return new FallbackRestClient();
4845
}
4946

50-
public static void main(String[] args) {
51-
SpringApplication.run(TestApplication.class, args);
47+
@Bean
48+
public FallbackClient fallback() {
49+
return new FallbackClient();
5250
}
51+
52+
public static void main(String[] args) {
53+
SpringApplication.run(FeignClientApplication.class, args);
54+
}
5355
}
5456

5557
@FeignClient(value = "myexample", fallback = FallbackRestClient.class)
56-
static interface RestClient {
57-
@RequestMapping(value = "/", method = RequestMethod.GET)
58+
public static interface ServiceRestClient {
59+
@RequestMapping(value="/", method=RequestMethod.GET)
5860
String hello();
5961
}
6062

61-
static class FallbackRestClient implements RestClient {
63+
static class FallbackRestClient implements ServiceRestClient {
6264

6365
@Override
6466
public String hello() {
6567
return "fallback";
6668
}
6769
}
68-
70+
6971
}

0 commit comments

Comments
 (0)