Skip to content

[Telemetry Audit] Move toolbar probes to their own toolbar.yaml file #27322

Closed
@data-sync-user

Description

@data-sync-user

The Task

This task is to move the toolbar-related probes out of the monolithic metrics.yaml file and into their own YAML file with a Toolbar tag.

You can use the FirefoxTelemetryUtility.sh script to create a new toolbar.yaml file.

More instructions on using the script can be found in our wiki: https://github.com/mozilla-mobile/firefox-ios/wiki/Adding-Glean-Telemetry-Events-and-Metrics#a-update-the-telemetry-specification-yaml-files

You can look up these probes in the Glean dictionary as well: https://dictionary.telemetry.mozilla.org/apps/firefox_ios

Probes to Move

  • toolbar.app_menu_button_tapped
  • toolbar.back_button_tapped
  • toolbar.back_long_press
  • toolbar.clear_search_button_tapped
  • toolbar.data_clearance_button_tapped
  • toolbar.forward_button_tapped
  • toolbar.forward_long_press
  • toolbar.home_button_tapped
  • toolbar.one_tap_new_tab_button_tapped
  • toolbar.one_tap_new_tab_long_press
  • toolbar.qr_scan_button_tapped
  • toolbar.reader_mode_button_tapped
  • toolbar.refresh_button_tapped
  • toolbar.search_button_tapped
  • toolbar.share_button_tapped
  • toolbar.site_info_button_tapped
  • toolbar.tab_tray_button_tapped
  • toolbar.tab_tray_long_press
  • awesomebar.drag_location_bar
  • awesomebar.location
  • awesomebar.query_time
  • awesomebar.search_result_impression
  • awesomebar.search_result_tap
  • awesomebar.share_button_tapped

Note: The Toolbar tag will be automatically applied at the top of your new toolbar.yaml file created with the FirefoxTelemetryUtility.sh script.

You will need to add the Toolbar tag to the tags.yaml file. Please preserve alphabetical ordering. The description you can use is as follows: Corresponds to the toolbar which contains both the address bar and the navigation bar.

Example

You can see an example of this type of work in the following PR: https://github.com/mozilla-mobile/firefox-ios/pull/27083

ℹ️ Reference Person

@ih-codes

┆Issue is synchronized with this Jira Task

Metadata

Metadata

Assignees

No one assigned

    Labels

    Contributor OKThis is a good issue for contributors interested in helping the projectGood first issueA good issue to be worked on for first time contributors

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions