Description
The Task
This task is to move the tabs panel (i.e. tabs tray) probes out of the monolithic metrics.yaml file and into their own YAML file with a TabsPanel tag.
You can use the FirefoxTelemetryUtility.sh script to create a new tabs_panel.yaml file.
More instructions on using the script can be found in our wiki: https://github.com/mozilla-mobile/firefox-ios/wiki/Adding-Glean-Telemetry-Events-and-Metrics#a-update-the-telemetry-specification-yaml-files
You can look up these probes in the Glean dictionary as well: https://dictionary.telemetry.mozilla.org/apps/firefox_ios
Probes to Move
- tabs_panel.close_all_tabs_sheet.option_selected
- tabs_panel.close_old_tabs_sheet.option_selected
- tabs_panel.done_button_tapped
- tabs_panel.new_tab_button_tapped
- tabs_panel.tab_closed
- tabs_panel.tab_mode_selected
- tabs_panel.tab_selected
- tabs_tray.new_private_tab_tapped
- tabs_tray.private_browsing_icon_tapped
- inactive_tabs_tray.inactive_tab_shown
- inactive_tabs_tray.inactive_tab_swipe_close
- inactive_tabs_tray.inactive_tabs_close_all_btn
- inactive_tabs_tray.open_inactive_tab
- inactive_tabs_tray.toggle_inactive_tab_tray
Note: The TabsPanel tag will be automatically applied at the top of your new tabs_panel.yaml file created with the FirefoxTelemetryUtility.sh script. You can delete the following from any of the probes as it will now be redundant:
metadata:
tags:
- TabsPanel
Example
You can see an example of this type of work in the following PR: https://github.com/mozilla-mobile/firefox-ios/pull/27083
ℹ️ Reference Person
┆Issue is synchronized with this Jira Task