Skip to content

Commit cf5d34e

Browse files
veneamueller
authored andcommitted
Make sign flip in place
1 parent d5857bb commit cf5d34e

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

sklearn/utils/extmath.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -441,4 +441,6 @@ def svd_flip(u, s, v):
441441
"""
442442
max_abs_cols = np.argmax(np.abs(u), axis=0)
443443
signs = np.sign(u[max_abs_cols, xrange(u.shape[1])])
444-
return u * signs, s, v * signs[:, np.newaxis]
444+
u *= signs
445+
v *= signs[:, np.newaxis]
446+
return u, s, v

0 commit comments

Comments
 (0)