Made explicit destructors for a bunch of interface / proxy objects.

Author: Yucheng Low

oss_src/cppipc/common/object_factory.cpp

@@ -5,3 +5,7 @@
  * This software may be modified and distributed under the terms
  * of the BSD license. See the LICENSE file for details.
  */
+#include <cppipc/ipc_object_base.hpp>
+namespace cppipc {
+ipc_object_base::~ipc_object_base() { }
+}

oss_src/cppipc/ipc_object_base.hpp

@@ -15,7 +15,10 @@
  */
 namespace cppipc {
 
-class EXPORT ipc_object_base: public std::enable_shared_from_this<ipc_object_base> { };
+class EXPORT ipc_object_base: public std::enable_shared_from_this<ipc_object_base> { 
+ public:
+  virtual ~ipc_object_base();
+};
 
 } // cppipc
 

oss_src/cppipc/magic_macros.hpp

@@ -107,6 +107,19 @@
  * };
  * \endcode
  */
+#define GENERATE_INTERFACE_NO_INLINE_DESTRUCTOR(base_name, proxy_name, functions) \
+    class base_name : public cppipc::ipc_object_base { \
+     public: \
+      typedef proxy_name proxy_object_type; \
+      virtual ~base_name(); \
+      inline virtual void save(graphlab::oarchive& oarc) const {} \
+      inline virtual void load(graphlab::iarchive& iarc) {}       \
+       BOOST_PP_SEQ_FOR_EACH(__GENERATE_BASE__, _, __ADD_PARENS__(functions)) \
+       REGISTRATION_BEGIN(base_name) \
+       BOOST_PP_SEQ_FOR_EACH(__GENERATE_REGISTRATION__, base_name, __ADD_PARENS__(functions)) \
+       REGISTRATION_END \
+    };
+
 #define GENERATE_INTERFACE(base_name, proxy_name, functions) \
     class base_name : public cppipc::ipc_object_base { \
      public: \
@@ -120,6 +133,8 @@
        REGISTRATION_END \
     }; 
 
+#define GENERATE_BASE_DESTRUCTOR(base_name) \
+    base_name::~base_name() { }
 
 
 
@@ -292,13 +307,20 @@
     class proxy_name; \
     GENERATE_INTERFACE(base_name, proxy_name, functions)
 
+#define GENERATE_INTERFACE_AND_PROXY_NO_INLINE_DESTRUCTOR(base_name, proxy_name, functions) \
+    class proxy_name; \
+    GENERATE_INTERFACE_NO_INLINE_DESTRUCTOR(base_name, proxy_name, functions)
 #else
 
 #define GENERATE_INTERFACE_AND_PROXY(base_name, proxy_name, functions) \
     class proxy_name; \
     GENERATE_INTERFACE(base_name, proxy_name, functions) \
-    GENERATE_PROXY(base_name, proxy_name, functions) 
+    GENERATE_PROXY(base_name, proxy_name, functions)
 
+#define GENERATE_INTERFACE_AND_PROXY_NO_INLINE_DESTRUCTOR(base_name, proxy_name, functions) \
+    class proxy_name; \
+    GENERATE_INTERFACE_NO_INLINE_DESTRUCTOR(base_name, proxy_name, functions) \
+    GENERATE_PROXY(base_name, proxy_name, functions)
 #endif
 
 #endif

oss_src/unity/lib/CMakeLists.txt

@@ -3,6 +3,7 @@ project(unity)
 make_library(unity_core
   SOURCES
     api/function_closure_info.cpp
+    api/destructor_impl.cpp
     variant_converter.cpp
     variant.cpp
     unity_global.cpp

oss_src/unity/lib/api/destructor_impl.cpp

@@ -0,0 +1,17 @@
+#include "unity_global_interface.hpp"
+#include "unity_graph_interface.hpp"
+#include "unity_sarray_builder_interface.hpp"
+#include "unity_sarray_interface.hpp"
+#include "unity_sframe_builder_interface.hpp"
+#include "unity_sframe_interface.hpp"
+#include "unity_sketch_interface.hpp"
+
+namespace graphlab {
+GENERATE_BASE_DESTRUCTOR(unity_global_base)
+GENERATE_BASE_DESTRUCTOR(unity_sgraph_base)
+GENERATE_BASE_DESTRUCTOR(unity_sarray_builder_base)
+GENERATE_BASE_DESTRUCTOR(unity_sarray_base)
+GENERATE_BASE_DESTRUCTOR(unity_sframe_builder_base)
+GENERATE_BASE_DESTRUCTOR(unity_sframe_base)
+GENERATE_BASE_DESTRUCTOR(unity_sketch_base)
+}

oss_src/unity/lib/api/unity_global_interface.hpp

@@ -48,7 +48,7 @@ class unity_global_base {
 
 typedef std::map<std::string, flexible_type> global_configuration_type;
 
-  GENERATE_INTERFACE_AND_PROXY(unity_global_base, unity_global_proxy,
+  GENERATE_INTERFACE_AND_PROXY_NO_INLINE_DESTRUCTOR(unity_global_base, unity_global_proxy,
       (std::vector<std::string>, list_toolkit_functions, )
       (std::vector<std::string>, list_toolkit_classes, )
       (global_configuration_type, describe_toolkit_function, (std::string))

oss_src/unity/lib/api/unity_graph_interface.hpp

@@ -52,7 +52,7 @@ class unity_sgraph_base {
 
 #endif
 
-GENERATE_INTERFACE_AND_PROXY(unity_sgraph_base, unity_graph_proxy,
+GENERATE_INTERFACE_AND_PROXY_NO_INLINE_DESTRUCTOR(unity_sgraph_base, unity_graph_proxy,
     (options_map_t, summary, )
     (std::vector<std::string>, get_vertex_fields, (size_t))
     (std::vector<std::string>, get_edge_fields, (size_t)(size_t))

oss_src/unity/lib/api/unity_sarray_builder_interface.hpp

@@ -15,7 +15,7 @@ namespace graphlab {
 
 class unity_sarray_base;
 
-GENERATE_INTERFACE_AND_PROXY(unity_sarray_builder_base, unity_sarray_builder_proxy,
+GENERATE_INTERFACE_AND_PROXY_NO_INLINE_DESTRUCTOR(unity_sarray_builder_base, unity_sarray_builder_proxy,
       (void, init, (size_t)(size_t)(flex_type_enum))
       (void, append, (const flexible_type&)(size_t))
       (void, append_multiple, (const std::vector<flexible_type>&)(size_t))

oss_src/unity/lib/api/unity_sarray_interface.hpp

@@ -19,7 +19,7 @@ namespace graphlab {
 class unity_sframe_base;
 typedef std::map<std::string, flexible_type> func_options_map;
 
-GENERATE_INTERFACE_AND_PROXY(unity_sarray_base, unity_sarray_proxy,
+GENERATE_INTERFACE_AND_PROXY_NO_INLINE_DESTRUCTOR(unity_sarray_base, unity_sarray_proxy,
       (void, construct_from_vector, (const std::vector<flexible_type>&)(flex_type_enum))
       (void, construct_from_const, (const flexible_type&)(size_t)(flex_type_enum))
       (void, construct_from_sarray_index, (std::string))

oss_src/unity/lib/api/unity_sframe_builder_interface.hpp

@@ -9,7 +9,7 @@ namespace graphlab {
 
 class unity_sframe_base;
 
-GENERATE_INTERFACE_AND_PROXY(unity_sframe_builder_base, unity_sframe_builder_proxy,
+GENERATE_INTERFACE_AND_PROXY_NO_INLINE_DESTRUCTOR(unity_sframe_builder_base, unity_sframe_builder_proxy,
       (void, init, (size_t)(size_t)(std::vector<std::string>)(std::vector<flex_type_enum>)(std::string))
       (void, append, (const std::vector<flexible_type>&)(size_t))
       (void, append_multiple, (const std::vector<std::vector<flexible_type>>&)(size_t))