Skip to content

Commit c72f2e6

Browse files
ferozcogatesn
authored andcommitted
improve logging (palantir#265)
* improve logging * oops * fix
1 parent 366b1b0 commit c72f2e6

File tree

2 files changed

+8
-3
lines changed

2 files changed

+8
-3
lines changed

pyls/json_rpc_server.py

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,12 @@ def write_message(self, message):
7676
if batch_response is not None:
7777
message = batch_response
7878

79-
log.debug("Sending %s", message)
79+
if isinstance(message, (JSONRPC20BatchResponse, JSONRPC20BatchRequest)):
80+
for msg in message:
81+
log.debug('Sending %s', msg._data)
82+
else:
83+
log.debug('Sending %s', message._data)
84+
8085
body = message.json
8186
content_length = len(body)
8287
response = (

pyls/rpc_manager.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,7 @@ def _handle_request(self, request):
117117
except JSONRPCDispatchException as e:
118118
output = _make_response(request, error=e.error._data)
119119
except Exception as e: # pylint: disable=broad-except
120-
log.exception('synchronous method handler exception')
120+
log.exception('synchronous method handler exception for request: %s', request)
121121
output = _make_response(request, error=JSONRPCServerError()._data)
122122
else:
123123
if request._id in self._received_requests:
@@ -149,7 +149,7 @@ def did_finish_callback(completed_future):
149149
output = _make_response(request, error=e.error._data)
150150
except Exception as e: # pylint: disable=broad-except
151151
# TODO(forozco): add more descriptive error
152-
log.exception('asynchronous method handler exception')
152+
log.exception('asynchronous method handler exception for request: %s', request)
153153
output = _make_response(request, error=JSONRPCServerError()._data)
154154
else:
155155
output = _make_response(request, result=result)

0 commit comments

Comments
 (0)