Fix conv1d segfault when weight doesn't require grad (pytorch#1646)

colesbury · soumith · commit 98581b9f7eab · 2017-05-24T20:46:32.000-04:00
Fixes pytorch#1600
diff --git a/torch/csrc/autograd/functions/convolution.cpp b/torch/csrc/autograd/functions/convolution.cpp
@@ -307,10 +307,12 @@ auto ConvBackward::apply(const variable_list& grad_outputs) -> variable_list {
   }
 
   if (k == 3) {
-    if (should_compute_output(0)) {
-        grad_input = view3d(*grad_input);
+    if (grad_input) {
+      grad_input = view3d(*grad_input);
+    }
+    if (grad_weight) {
+      grad_weight = view3d(*grad_weight);
     }
-    grad_weight = view3d(*grad_weight);
   }
 
   auto outputs =  as_tensor_list(std::move(grad_input),

Original file line number	Diff line number	Diff line change
`@@ -307,10 +307,12 @@ auto ConvBackward::apply(const variable_list& grad_outputs) -> variable_list {`
`307`	`307`	`}`
`308`	`308`
`309`	`309`	`if (k == 3) {`
`310`		`- if (should_compute_output(0)) {`
`311`		`- grad_input = view3d(*grad_input);`
	`310`	`+ if (grad_input) {`
	`311`	`+ grad_input = view3d(*grad_input);`
	`312`	`+ }`
	`313`	`+ if (grad_weight) {`
	`314`	`+ grad_weight = view3d(*grad_weight);`
`312`	`315`	`}`
`313`		`- grad_weight = view3d(*grad_weight);`
`314`	`316`	`}`
`315`	`317`
`316`	`318`	`auto outputs = as_tensor_list(std::move(grad_input),`