SERVER-14938 Remove string streaming operators from OpTime and Date_t

Author: stbrody

src/mongo/bson/optime.cpp

@@ -42,7 +42,4 @@ namespace mongo {
         return OpTime(t, i);
     }
 
-    std::ostream& operator<<(std::ostream &s, const OpTime &ot) {
-        return s << ot.toString();
-    }
 }

src/mongo/bson/optime.h

@@ -144,6 +144,4 @@ namespace mongo {
     };
 #pragma pack()
 
-    std::ostream& operator<<(std::ostream &s, const OpTime &ot);
-
 } // namespace mongo

src/mongo/db/repl/repl_coordinator_impl_test.cpp

@@ -50,6 +50,18 @@
 #include "mongo/util/log.h"
 
 namespace mongo {
+
+    // So that you can ASSERT_EQUALS two OpTimes
+    std::ostream& operator<<( std::ostream &s, const OpTime &ot ) {
+        s << ot.toString();
+        return s;
+    }
+    // So that you can ASSERT_EQUALS two Date_ts
+    std::ostream& operator<<( std::ostream &s, const Date_t &t ) {
+        s << t.toString();
+        return s;
+    }
+
 namespace repl {
 namespace {
 

src/mongo/db/repl/topology_coordinator_impl_test.cpp

@@ -36,6 +36,18 @@
 #include "mongo/util/time_support.h"
 
 namespace mongo {
+
+    // So that you can ASSERT_EQUALS two OpTimes
+    std::ostream& operator<<( std::ostream &s, const OpTime &ot ) {
+        s << ot.toString();
+        return s;
+    }
+    // So that you can ASSERT_EQUALS two Date_ts
+    std::ostream& operator<<( std::ostream &s, const Date_t &t ) {
+        s << t.toString();
+        return s;
+    }
+
 namespace repl {
 namespace {
 

src/mongo/util/time_support.cpp

@@ -70,10 +70,6 @@ namespace mongo {
         }
     }
 
-    std::ostream& operator<<(std::ostream &s, const Date_t &t) {
-        return s << t.toString();
-    }
-
     // jsTime_virtual_skew is just for testing. a test command manipulates it.
     long long jsTime_virtual_skew = 0;
     boost::thread_specific_ptr<long long> jsTime_virtual_thread_skew;

src/mongo/util/time_support.h

@@ -64,8 +64,6 @@ namespace mongo {
         bool isFormatable() const;
     };
 
-    std::ostream& operator<<(std::ostream &s, const Date_t &t);
-
     // uses ISO 8601 dates without trailing Z
     // colonsOk should be false when creating filenames
     std::string terseCurrentTime(bool colonsOk=true);