Uses reduce(into:,_) instead of reduce(_,_)` to avoid intermediate arrays allocations

valeriyvan · valeriyvan · commit 165e8b0dff1a · 2019-10-25T22:07:12.000+02:00
diff --git a/Sources/CryptoSwift/SHA3.swift b/Sources/CryptoSwift/SHA3.swift
@@ -275,8 +275,8 @@ extension SHA3: Updatable {
     self.accumulated.removeFirst(processedBytes)
 
     // TODO: verify performance, reduce vs for..in
-    let result = self.accumulatedHash.reduce(Array<UInt8>()) { (result, value) -> Array<UInt8> in
-      result + value.bigEndian.bytes()
+    let result = self.accumulatedHash.reduce(into: Array<UInt8>()) { (result, value) in
+      result += value.bigEndian.bytes()
     }
 
     // reset hash value for instance

Original file line number	Diff line number	Diff line change
`@@ -275,8 +275,8 @@ extension SHA3: Updatable {`
`275`	`275`	`self.accumulated.removeFirst(processedBytes)`
`276`	`276`
`277`	`277`	`// TODO: verify performance, reduce vs for..in`
`278`		`- let result = self.accumulatedHash.reduce(Array<UInt8>()) { (result, value) -> Array<UInt8> in`
`279`		`- result + value.bigEndian.bytes()`
	`278`	`+ let result = self.accumulatedHash.reduce(into: Array<UInt8>()) { (result, value) in`
	`279`	`+ result += value.bigEndian.bytes()`
`280`	`280`	`}`
`281`	`281`
`282`	`282`	`// reset hash value for instance`