Skip to content

Commit 2210263

Browse files
tirodkarkhandpur
authored andcommitted
iOS 13 Keyboard key fix.
Cherry-picked from e86ac63. PiperOrigin-RevId: 252922617
1 parent 8ae8b20 commit 2210263

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

EarlGrey/Core/GREYKeyboard.m

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ + (void)initialize {
156156
// Note: more, numbers label must be after shift and SHIFT labels, because it is also used for
157157
// the key for switching between keyplanes.
158158
gShiftKeyLabels =
159-
@[ @"shift", @"Shift", @"SHIFT", @"more, symbols", @"more, numbers", @"more", @"MORE" ];
159+
@[ @"shift", @"Shift", @"SHIFT", @"more, symbols", @"more, numbers", @"numbers", @"more", @"MORE" ];
160160

161161
NSCharacterSet *lowerCaseSet = [NSCharacterSet lowercaseLetterCharacterSet];
162162
gAlphabeticKeyplaneCharacters = [NSMutableCharacterSet uppercaseLetterCharacterSet];
@@ -224,11 +224,13 @@ + (BOOL)typeString:(NSString *)string
224224
GREYLogVerbose(@"Detected a non-alphabetic key.");
225225
// Switch to numbers/symbols keyplane if we are on alphabetic keyplane.
226226
if ([GREYKeyboard grey_isAlphabeticKeyplaneShown]) {
227-
id moreNumbersKey = [GREYKeyboard grey_waitAndfindKeyForCharacter:@"more, numbers"];
227+
NSString *moreNumberKeyAxLabel = iOS13_OR_ABOVE() ? @"numbers" : @"more, numbers";
228+
id moreNumbersKey = [GREYKeyboard grey_waitAndfindKeyForCharacter:moreNumberKeyAxLabel];
228229
if (!moreNumbersKey) {
229-
return [GREYKeyboard grey_setErrorForkeyNotFoundWithAccessibilityLabel:@"more, numbers"
230-
forTypingString:string
231-
error:errorOrNil];
230+
return
231+
[GREYKeyboard grey_setErrorForkeyNotFoundWithAccessibilityLabel:moreNumberKeyAxLabel
232+
forTypingString:string
233+
error:errorOrNil];
232234
}
233235
[GREYKeyboard grey_tapKey:moreNumbersKey error:errorOrNil];
234236
key = [GREYKeyboard grey_waitAndfindKeyForCharacter:characterAsString];

0 commit comments

Comments
 (0)