fix jezzmemo#67

Jezz · Jezz · commit 8bdd976dd54a · 2019-05-31T22:52:52.000+08:00
diff --git a/JJException.xcodeproj/project.xcworkspace/xcuserdata/jezz.xcuserdatad/UserInterfaceState.xcuserstate b/JJException.xcodeproj/project.xcworkspace/xcuserdata/jezz.xcuserdatad/UserInterfaceState.xcuserstate
diff --git a/JJException.xcodeproj/xcuserdata/jezz.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist b/JJException.xcodeproj/xcuserdata/jezz.xcuserdatad/xcdebugger/Breakpoints_v2.xcbkptlist
@@ -28,7 +28,7 @@
             ignoreCount = "0"
             continueAfterRunningActions = "No"
             filePath = "JJException/ViewController.m"
-            timestampString = "577522874.469534"
+            timestampString = "581006976.523271"
             startingColumnNumber = "9223372036854775807"
             endingColumnNumber = "9223372036854775807"
             startingLineNumber = "73"
diff --git a/JJException/Source/MRC/NSMutableDictionary+MutableDictionaryHook.m b/JJException/Source/MRC/NSMutableDictionary+MutableDictionaryHook.m
@@ -38,7 +38,7 @@ - (void) hookRemoveObjectForKey:(id)key {
 }
 
 - (void) hookSetObject:(id)object forKeyedSubscript:(id<NSCopying>)key {
-    if (object && key ) {
+    if (key) {
         [self hookSetObject:object forKeyedSubscript:key];
     } else {
         handleCrashException(JJExceptionGuardDictionaryContainer,[NSString stringWithFormat:@"NSMutableDictionary setObject object:%@ and forKeyedSubscript:%@",object,key],self);
diff --git a/JJExceptionTests/JJExceptionTests.m b/JJExceptionTests/JJExceptionTests.m
@@ -95,6 +95,8 @@ - (void)testMutableDictionaryException{
     NSMutableDictionary *forKeyedSubscript = @{@"name" : @"text"}.mutableCopy;
     NSString *subscript = nil;
     forKeyedSubscript[subscript] = @(25);
+    forKeyedSubscript[@"name"] = nil;
+    XCTAssert(forKeyedSubscript.count == 0);
 }
 
 - (void)testZombieException{

Original file line number	Diff line number	Diff line change
`@@ -38,7 +38,7 @@ - (void) hookRemoveObjectForKey:(id)key {`
`38`	`38`	`}`
`39`	`39`
`40`	`40`	`- (void) hookSetObject:(id)object forKeyedSubscript:(id<NSCopying>)key {`
`41`		`- if (object && key ) {`
	`41`	`+ if (key) {`
`42`	`42`	`[self hookSetObject:object forKeyedSubscript:key];`
`43`	`43`	`} else {`
`44`	`44`	`handleCrashException(JJExceptionGuardDictionaryContainer,[NSString stringWithFormat:@"NSMutableDictionary setObject object:%@ and forKeyedSubscript:%@",object,key],self);`
Original file line number	Diff line number	Diff line change
`@@ -95,6 +95,8 @@ - (void)testMutableDictionaryException{`
`95`	`95`	`NSMutableDictionary *forKeyedSubscript = @{@"name" : @"text"}.mutableCopy;`
`96`	`96`	`NSString *subscript = nil;`
`97`	`97`	`forKeyedSubscript[subscript] = @(25);`
	`98`	`+ forKeyedSubscript[@"name"] = nil;`
	`99`	`+ XCTAssert(forKeyedSubscript.count == 0);`
`98`	`100`	`}`
`99`	`101`
`100`	`102`	`- (void)testZombieException{`