Skip to content

Commit 49db540

Browse files
skchofacebook-github-bot
authored andcommitted
[ConfigImpact] Update message of issue
Reviewed By: ezgicicek Differential Revision: D32696198 fbshipit-source-id: c13a743721
1 parent 7d6e235 commit 49db540

File tree

3 files changed

+8
-2
lines changed

3 files changed

+8
-2
lines changed

infer/src/integration/Differential.ml

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -421,11 +421,13 @@ module ConfigImpactItem = struct
421421
(UncheckedCallee.is_known_expensive x) )
422422
in
423423
let qualifier =
424-
Format.asprintf "Function call%s to %a %s %a **without GK/QE**."
424+
Format.asprintf
425+
"Function call%s to %a %s %a **without GK/QE**, which might cause new unexpected behavior. \
426+
%s"
425427
(if is_singleton then "" else "s")
426428
UncheckedCallee.pp_without_location_list unchecked_callees
427429
(if is_singleton then "is" else "are")
428-
pp_change_type change_type
430+
pp_change_type change_type FbGKInteraction.action_message
429431
in
430432
(* Note: It takes only one trace among the callees. *)
431433
let trace = List.hd_exn unchecked_callees |> UncheckedCallee.make_err_trace in

infer/src/opensource/FbGKInteraction.ml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,3 +28,5 @@ type known_expensiveness = KnownCheap | KnownExpensive
2828
module ExpensivenessModel = struct
2929
let dispatcher _ _ _ = None
3030
end
31+
32+
let action_message = "Please either gate it or make sure that the function call is harmless."

infer/src/opensource/FbGKInteraction.mli

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,3 +26,5 @@ type known_expensiveness = KnownCheap | KnownExpensive
2626
module ExpensivenessModel : sig
2727
val dispatcher : 'tenv -> 'pname -> 'args -> 'known_expensivene option
2828
end
29+
30+
val action_message : string

0 commit comments

Comments
 (0)