[CCBM] Remove ConfigChecksBetweenMarkers checker

Reviewed By: ngorogiannis

Differential Revision: D32677613

fbshipit-source-id: 7e1272cef8

Author: skcho

Makefile

@@ -139,8 +139,7 @@ BUILD_SYSTEMS_TESTS += \
   fb_differential_of_config_impact_report_objc
 
 DIRECT_TESTS += \
-  objc_fb-config-impact \
-  objc_fb-gk-interaction
+  objc_fb-config-impact
 endif
 
 
@@ -228,7 +227,6 @@ DIRECT_TESTS += \
   java_fb-config-impact \
   java_fb-config-impact-paths \
   java_fb-config-impact-strict \
-  java_fb-gk-interaction \
   java_fb-immutability \
   java_fb-performance
 endif

infer/man/man1/infer-analyze.txt

@@ -51,16 +51,6 @@ OPTIONS
            reactive analysis should start. Source files should be specified
            relative to project root or be absolute
 
-       --config-checks-between-markers
-           Activates: checker config-checks-between-markers: [EXPERIMENTAL]
-           Collects config checks between marker start and end. (Conversely:
-           --no-config-checks-between-markers)
-
-       --config-checks-between-markers-only
-           Activates: Enable config-checks-between-markers and disable all
-           other checkers (Conversely:
-           --no-config-checks-between-markers-only)
-
        --config-impact-analysis
            Activates: checker config-impact-analysis: [EXPERIMENTAL] Collects
            function that are called without config checks. (Conversely:

infer/man/man1/infer-full.txt

@@ -267,16 +267,6 @@ OPTIONS
            escaped for the shell, eg coming from Xcode (can be specified
            multiple times)           See also infer-capture(1).
 
-       --config-checks-between-markers
-           Activates: checker config-checks-between-markers: [EXPERIMENTAL]
-           Collects config checks between marker start and end. (Conversely:
-           --no-config-checks-between-markers)           See also infer-analyze(1).
-
-       --config-checks-between-markers-only
-           Activates: Enable config-checks-between-markers and disable all
-           other checkers (Conversely:
-           --no-config-checks-between-markers-only)           See also infer-analyze(1).
-
        --config-impact-analysis
            Activates: checker config-impact-analysis: [EXPERIMENTAL] Collects
            function that are called without config checks. (Conversely:
@@ -472,7 +462,6 @@ OPTIONS
              COMPONENT_WITH_MULTIPLE_FACTORY_METHODS (enabled by default),
              CONDITION_ALWAYS_FALSE (disabled by default),
              CONDITION_ALWAYS_TRUE (disabled by default),
-             CONFIG_CHECKS_BETWEEN_MARKERS (disabled by default),
              CONFIG_IMPACT (disabled by default),
              CONFIG_IMPACT_STRICT (disabled by default),
              CONSTANT_ADDRESS_DEREFERENCE (disabled by default),

infer/man/man1/infer-report.txt

@@ -142,7 +142,6 @@ OPTIONS
              COMPONENT_WITH_MULTIPLE_FACTORY_METHODS (enabled by default),
              CONDITION_ALWAYS_FALSE (disabled by default),
              CONDITION_ALWAYS_TRUE (disabled by default),
-             CONFIG_CHECKS_BETWEEN_MARKERS (disabled by default),
              CONFIG_IMPACT (disabled by default),
              CONFIG_IMPACT_STRICT (disabled by default),
              CONSTANT_ADDRESS_DEREFERENCE (disabled by default),

infer/man/man1/infer.txt

@@ -267,16 +267,6 @@ OPTIONS
            escaped for the shell, eg coming from Xcode (can be specified
            multiple times)           See also infer-capture(1).
 
-       --config-checks-between-markers
-           Activates: checker config-checks-between-markers: [EXPERIMENTAL]
-           Collects config checks between marker start and end. (Conversely:
-           --no-config-checks-between-markers)           See also infer-analyze(1).
-
-       --config-checks-between-markers-only
-           Activates: Enable config-checks-between-markers and disable all
-           other checkers (Conversely:
-           --no-config-checks-between-markers-only)           See also infer-analyze(1).
-
        --config-impact-analysis
            Activates: checker config-impact-analysis: [EXPERIMENTAL] Collects
            function that are called without config checks. (Conversely:
@@ -472,7 +462,6 @@ OPTIONS
              COMPONENT_WITH_MULTIPLE_FACTORY_METHODS (enabled by default),
              CONDITION_ALWAYS_FALSE (disabled by default),
              CONDITION_ALWAYS_TRUE (disabled by default),
-             CONFIG_CHECKS_BETWEEN_MARKERS (disabled by default),
              CONFIG_IMPACT (disabled by default),
              CONFIG_IMPACT_STRICT (disabled by default),
              CONSTANT_ADDRESS_DEREFERENCE (disabled by default),

infer/src/backend/Payloads.ml

@@ -13,7 +13,6 @@ type t =
   ; biabduction: BiabductionSummary.t option
   ; buffer_overrun_analysis: BufferOverrunAnalysisSummary.t option
   ; buffer_overrun_checker: BufferOverrunCheckerSummary.t option
-  ; config_checks_between_markers: ConfigChecksBetweenMarkers.Summary.t option
   ; config_impact_analysis: ConfigImpactAnalysis.Summary.t option
   ; cost: CostDomain.summary option
   ; disjunctive_demo: DisjunctiveDemo.domain option
@@ -47,8 +46,6 @@ let fields =
     ~biabduction:(fun f -> mk_pe f "Biabduction" BiabductionSummary.pp)
     ~buffer_overrun_analysis:(fun f -> mk f "BufferOverrunAnalysis" BufferOverrunAnalysisSummary.pp)
     ~buffer_overrun_checker:(fun f -> mk f "BufferOverrunChecker" BufferOverrunCheckerSummary.pp)
-    ~config_checks_between_markers:(fun f ->
-      mk f "ConfigChecksBetweenMarkers" ConfigChecksBetweenMarkers.Summary.pp )
     ~config_impact_analysis:(fun f -> mk f "ConfigImpactAnalysis" ConfigImpactAnalysis.Summary.pp)
     ~cost:(fun f -> mk f "Cost" CostDomain.pp_summary)
     ~disjunctive_demo:(fun f -> mk f "Disjunctive Demo" DisjunctiveDemo.pp_domain)
@@ -76,7 +73,6 @@ let empty =
   ; biabduction= None
   ; buffer_overrun_analysis= None
   ; buffer_overrun_checker= None
-  ; config_checks_between_markers= None
   ; config_impact_analysis= None
   ; cost= None
   ; disjunctive_demo= None

infer/src/backend/Payloads.mli

@@ -17,7 +17,6 @@ include sig
     ; biabduction: BiabductionSummary.t option
     ; buffer_overrun_analysis: BufferOverrunAnalysisSummary.t option
     ; buffer_overrun_checker: BufferOverrunCheckerSummary.t option
-    ; config_checks_between_markers: ConfigChecksBetweenMarkers.Summary.t option
     ; config_impact_analysis: ConfigImpactAnalysis.Summary.t option
     ; cost: CostDomain.summary option
     ; disjunctive_demo: DisjunctiveDemo.domain option

infer/src/backend/registerCheckers.ml

@@ -194,13 +194,6 @@ let all_checkers =
            interprocedural Payloads.Fields.annot_map AnnotationReachability.checker
          in
          [(annot_reach, Java); (annot_reach, Clang)] ) }
-  ; { checker= ConfigChecksBetweenMarkers
-    ; callbacks=
-        (let checker =
-           interprocedural Payloads.Fields.config_checks_between_markers
-             ConfigChecksBetweenMarkers.checker
-         in
-         [(checker, Clang); (checker, Java)] ) }
   ; { checker= ConfigImpactAnalysis
     ; callbacks=
         (let checker =

infer/src/base/Checker.ml

@@ -13,7 +13,6 @@ type t =
   | Biabduction
   | BufferOverrunAnalysis
   | BufferOverrunChecker
-  | ConfigChecksBetweenMarkers
   | ConfigImpactAnalysis
   | Cost
   | DisjunctiveDemo
@@ -153,23 +152,6 @@ let config_unsafe checker =
       ; cli_flags= Some {deprecated= []; show_in_help= true}
       ; enabled_by_default= false
       ; activates= [BufferOverrunAnalysis] }
-  | ConfigChecksBetweenMarkers ->
-      { id= "config-checks-between-markers"
-      ; kind=
-          UserFacing
-            { title= "Config Checks between Markers"
-            ; markdown_body=
-                "This checker collects config checkings in some program regions determined by \
-                 pairs of marker-starts and marker-ends. The set of config checking functions, \
-                 marker-start functions, and marker-end functions is hardcoded and empty by \
-                 default for now, so to use this checker, please modify the code directly in \
-                 [FbGKInteraction.ml](https://github.com/facebook/infer/tree/main/infer/src/opensource)."
-            }
-      ; support= supports_clang_and_java_experimental
-      ; short_documentation= "[EXPERIMENTAL] Collects config checks between marker start and end."
-      ; cli_flags= Some {deprecated= []; show_in_help= true}
-      ; enabled_by_default= false
-      ; activates= [] }
   | ConfigImpactAnalysis ->
       { id= "config-impact-analysis"
       ; kind=

infer/src/base/Checker.mli

@@ -12,7 +12,6 @@ type t =
   | Biabduction
   | BufferOverrunAnalysis
   | BufferOverrunChecker
-  | ConfigChecksBetweenMarkers
   | ConfigImpactAnalysis
   | Cost
   | DisjunctiveDemo