[tests] [5/n] Adapt and copy to Pulse a test about the implementation of ObjC method names

dulmarod · facebook-github-bot · commit d93404003579 · 2021-11-18T03:07:15.000-08:00
Summary: This is a test of the frontend; that we handle the instance and class names correctly.

Reviewed By: skcho

Differential Revision: D32431910

fbshipit-source-id: 72dba72ba
diff --git a/infer/tests/codetoanalyze/objc/biabduction/Makefile b/infer/tests/codetoanalyze/objc/biabduction/Makefile
@@ -15,7 +15,6 @@ INFERPRINT_OPTIONS = --issues-tests
 SOURCES_DEFAULT = \
   memory_leaks_benchmark/NSString_models_tests.m \
   npe/dynamic_dispatch.m \
-  npe/Npe_with_equal_names.m \
   npe/block.m \
   npe/ivar_blocks.m \
   npe/skip_method_with_nil_object.m \
diff --git a/infer/tests/codetoanalyze/objc/biabduction/issues.exp b/infer/tests/codetoanalyze/objc/biabduction/issues.exp
@@ -83,7 +83,6 @@ codetoanalyze/objc/biabduction/subtyping/KindOfClassExample.m, shouldThrowDivide
 codetoanalyze/objc/biabduction/subtyping/KindOfClassExample.m, shouldThrowDivideByZero3, 3, DIVIDE_BY_ZERO, no_bucket, ERROR, [start of procedure shouldThrowDivideByZero3(),start of procedure init,return from a call to Derived.init,Taking true branch]
 codetoanalyze/objc/biabduction/variadic_methods/premature_nil_termination.m, PrematureNilTermA.nilInArrayWithObjects, 5, PREMATURE_NIL_TERMINATION_ARGUMENT, B1, WARNING, [start of procedure nilInArrayWithObjects]
 codetoanalyze/objc/biabduction/memory_leaks_benchmark/NSString_models_tests.m, StringInitA.hexStringValue, 11, BIABDUCTION_MEMORY_LEAK, no_bucket, ERROR, [start of procedure hexStringValue,Skipping CFStringCreateWithBytesNoCopy(): method has no implementation,Taking false branch]
-codetoanalyze/objc/biabduction/npe/Npe_with_equal_names.m, EqualNamesTest, 3, NULL_DEREFERENCE, B1, ERROR, [start of procedure EqualNamesTest(),start of procedure meth,return from a call to EqualNamesA.meth]
 codetoanalyze/objc/biabduction/npe/Nsstring_nil_args.m, initWithFormatBad, 3, NULL_DEREFERENCE, B1, ERROR, [start of procedure initWithFormatBad()]
 codetoanalyze/objc/biabduction/npe/Nsstring_nil_args.m, stringByAppendingStringBad, 2, NULL_DEREFERENCE, B1, ERROR, [start of procedure stringByAppendingStringBad()]
 codetoanalyze/objc/biabduction/npe/Nsstring_nil_args.m, stringWithStringBad, 2, NULL_DEREFERENCE, B1, ERROR, [start of procedure stringWithStringBad(),start of procedure nullableMethod(),return from a call to nullableMethod]
diff --git a/infer/tests/codetoanalyze/objc/pulse/issues.exp b/infer/tests/codetoanalyze/objc/pulse/issues.exp
@@ -8,6 +8,7 @@ codetoanalyze/objc/pulse/memory_leaks/MemoryLeaks.m, call_bridge_interproc_leak_
 codetoanalyze/objc/pulse/memory_leaks/MemoryLeaks.m, call_cfrelease_interproc_leak_ok_FP, 2, MEMORY_LEAK, no_bucket, ERROR, [allocation part of the trace starts here,allocated by `CFLocaleCreate (custom malloc)` here,memory becomes unreachable here]
 codetoanalyze/objc/pulse/memory_leaks/MemoryLeaksInBlocks.m, block_captured_var_leak_bad, 6, MEMORY_LEAK, no_bucket, ERROR, [allocation part of the trace starts here,allocated by `malloc` here,memory becomes unreachable here]
 codetoanalyze/objc/pulse/memory_leaks/MemoryLeaksInBlocks.m, objc_blockblock_free_ok_npe_latent_FP_2, 1, NULLPTR_DEREFERENCE_LATENT, no_bucket, ERROR, [source of the null value part of the trace starts here,is the null pointer,null pointer dereference part of the trace starts here,parameter `x` of objc_blockblock_free_ok_npe_latent_FP_2,invalid access occurs here]
+codetoanalyze/objc/pulse/null_deref/FrontendEqualNames.m, EqualNamesInstanceNPEBad, 3, NULLPTR_DEREFERENCE, no_bucket, ERROR, [in call to `EqualNamesA.meth`,is the null pointer,returned,return from call to `EqualNamesA.meth`,assigned,invalid access occurs here]
 codetoanalyze/objc/pulse/null_deref/IvarsInheritanceNPE.m, fields_set_up_correctly_npe_bad, 3, NULLPTR_DEREFERENCE, no_bucket, ERROR, [is the null pointer,assigned,invalid access occurs here]
 codetoanalyze/objc/pulse/null_deref/NPEBlocks.m, Singleton.dispatch_once_captured_vars_bad, 8, NULLPTR_DEREFERENCE, no_bucket, ERROR, [is the null pointer,assigned,in call to `objc_blockSingleton.dispatch_once_captured_vars_bad_2`,parameter `x` of objc_blockSingleton.dispatch_once_captured_vars_bad_2,assigned,return from call to `objc_blockSingleton.dispatch_once_captured_vars_bad_2`,invalid access occurs here]
 codetoanalyze/objc/pulse/null_deref/NPEBlocks.m, captured_npe_bad, 5, NULLPTR_DEREFERENCE, no_bucket, ERROR, [is the null pointer,assigned,when calling `objc_blockcaptured_npe_bad_4` here,parameter `x` of objc_blockcaptured_npe_bad_4,invalid access occurs here]
diff --git a/infer/tests/codetoanalyze/objc/pulse/null_deref/FrontendEqualNames.m b/infer/tests/codetoanalyze/objc/pulse/null_deref/FrontendEqualNames.m
@@ -30,13 +30,13 @@ - (EqualNamesA*)meth {
 
 @end
 
-int EqualNamesTest() {
+int EqualNamesInstanceNPEBad() {
   EqualNamesA* para = [EqualNamesA new];
   EqualNamesA* a = [para meth];
   return a->x;
 }
 
-int EqualNamesTest2(EqualNamesA* para) {
+int EqualNamesClassNoNPEGood(EqualNamesA* para) {
   EqualNamesA* a = [EqualNamesA meth];
   return a->x;
 }

Original file line number	Diff line number	Diff line change
`@@ -30,13 +30,13 @@ - (EqualNamesA*)meth {`
`30`	`30`
`31`	`31`	`@end`
`32`	`32`
`33`		`-int EqualNamesTest() {`
	`33`	`+int EqualNamesInstanceNPEBad() {`
`34`	`34`	`EqualNamesA* para = [EqualNamesA new];`
`35`	`35`	`EqualNamesA* a = [para meth];`
`36`	`36`	`return a->x;`
`37`	`37`	`}`
`38`	`38`
`39`		`-int EqualNamesTest2(EqualNamesA* para) {`
	`39`	`+int EqualNamesClassNoNPEGood(EqualNamesA* para) {`
`40`	`40`	`EqualNamesA* a = [EqualNamesA meth];`
`41`	`41`	`return a->x;`
`42`	`42`	`}`