Merge pull request #55645 from nextcloud/bugfix/noid/comments-by-apps

Fix comments when used by other apps

Author: nickvergessen

apps/comments/lib/Collaboration/CommentersSorter.php

@@ -27,6 +27,10 @@ public function getId(): string {
 	 * @param array $context
 	 */
 	public function sort(array &$sortArray, array $context): void {
+		if (!isset($context['itemType'], $context['itemId'])) {
+			return;
+		}
+
 		$commenters = $this->retrieveCommentsInformation($context['itemType'], $context['itemId']);
 		if (count($commenters) === 0) {
 			return;

apps/comments/src/mixins/CommentView.ts

@@ -27,6 +27,7 @@ export default defineComponent({
 				key: 'editor',
 			},
 			userData: {},
+			currentResourceId: this.resourceId,
 		}
 	},
 	methods: {
@@ -40,8 +41,8 @@ export default defineComponent({
 			const { data } = await axios.get(generateOcsUrl('core/autocomplete/get'), {
 				params: {
 					search,
-					itemType: 'files',
-					itemId: this.resourceId,
+					itemType: this.resourceType,
+					itemId: this.currentResourceId,
 					sorter: 'commenters|share-recipients',
 					limit: loadState('comments', 'maxAutoCompleteResults'),
 				},

apps/comments/src/views/Comments.vue

@@ -110,7 +110,6 @@ export default {
 			loading: false,
 			done: false,
 
-			currentResourceId: this.resourceId,
 			offset: 0,
 			comments: [],
 
@@ -158,7 +157,7 @@ export default {
 		async update(resourceId) {
 			this.currentResourceId = resourceId
 			this.resetState()
-			this.getComments()
+			await this.getComments()
 		},
 
 		/**
@@ -206,8 +205,13 @@ export default {
 					this.done = true
 				}
 
+				// Ensure actor id is a string
+				for (const comment of comments) {
+					comment.props.actorId = comment.props.actorId.toString()
+				}
+
 				// Insert results
-				this.comments.push(...comments)
+				this.comments = [...this.comments, ...comments]
 
 				// Increase offset for next fetch
 				this.offset += DEFAULT_LIMIT