Skip to content

Commit 8161809

Browse files
author
Christoph Ortner
committed
set only the linear parameters
1 parent 4406009 commit 8161809

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

src/fit_model.jl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@ export acefit!, assemble, compute_errors
1414

1515
_get_Vref(model::ACEPotential) = model.model.Vref
1616

17-
__set_params!(model::ACEPotential, coeffs) = ACEpotentials.Models.set_parameters!(model, coeffs)
18-
1917
default_weights() = Dict("default"=>Dict("E"=>30.0, "F"=>1.0, "V"=>1.0))
2018

2119
function _make_prior(model::ACEpotentials.Models.ACEPotential, smoothness, P)
@@ -163,7 +161,7 @@ function acefit!(raw_data::AbstractArray{<: AbstractSystem}, model;
163161
coeffs = P \ result["C"]
164162

165163
# dispatch setting of parameters
166-
__set_params!(model, coeffs)
164+
ACEpotentials.Models.set_linear_parameters!(model, coeffs)
167165

168166
if haskey(result, "committee")
169167
co_coeffs = result["committee"]

src/models/calculators.jl

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -54,6 +54,17 @@ function set_parameters!(V::ACEPotential, θ::AbstractVector)
5454
return set_parameters!(V, ps)
5555
end
5656

57+
function set_linear_parameters!(V::ACEPotential{<: ACEModel}, θ::AbstractVector)
58+
ps = V.ps
59+
ps1 = (WB = ps.WB, Wpair = ps.Wpair,)
60+
ps1_vec, _restruct = destructure(ps1)
61+
ps2 = _restruct(θ)
62+
ps3 = deepcopy(ps)
63+
ps3.WB[:] = ps2.WB
64+
ps3.Wpair[:] = ps2.Wpair
65+
return set_parameters!(V, ps3)
66+
end
67+
5768
# ---------------------------------------------------------------
5869
# AtomsCalculatorsUtilities / SitePotential based implementation
5970
#

0 commit comments

Comments
 (0)