Skip to content

Commit 3dbd58b

Browse files
chore: Update document test to add other feature data types and fix feature logging (feast-dev#4872)
Signed-off-by: Francisco Javier Arceo <[email protected]>
1 parent 7df287e commit 3dbd58b

File tree

3 files changed

+25
-3
lines changed

3 files changed

+25
-3
lines changed

sdk/python/tests/data/data_creator.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -84,6 +84,8 @@ def get_feature_values_for_dtype(
8484
def create_document_dataset() -> pd.DataFrame:
8585
data = {
8686
"item_id": [1, 2, 3],
87+
"string_feature": ["a", "b", "c"],
88+
"float_feature": [1.0, 2.0, 3.0],
8789
"embedding_float": [[4.0, 5.0], [1.0, 2.0], [3.0, 4.0]],
8890
"embedding_double": [[4.0, 5.0], [1.0, 2.0], [3.0, 4.0]],
8991
"ts": [

sdk/python/tests/integration/feature_repos/universal/feature_views.py

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
from feast.data_source import DataSource, RequestSource
1818
from feast.feature_view_projection import FeatureViewProjection
1919
from feast.on_demand_feature_view import PandasTransformation, SubstraitTransformation
20-
from feast.types import Array, FeastType, Float32, Float64, Int32, Int64
20+
from feast.types import Array, FeastType, Float32, Float64, Int32, Int64, String
2121
from tests.integration.feature_repos.universal.entities import (
2222
customer,
2323
driver,
@@ -160,8 +160,20 @@ def create_item_embeddings_feature_view(source, infer_features: bool = False):
160160
schema=None
161161
if infer_features
162162
else [
163-
Field(name="embedding_double", dtype=Array(Float64)),
164-
Field(name="embedding_float", dtype=Array(Float32)),
163+
Field(
164+
name="embedding_double",
165+
dtype=Array(Float64),
166+
vector_index=True,
167+
vector_search_metric="L2",
168+
),
169+
Field(
170+
name="embedding_float",
171+
dtype=Array(Float32),
172+
vector_index=True,
173+
vector_search_metric="L2",
174+
),
175+
Field(name="string_feature", dtype=String),
176+
Field(name="float_feature", dtype=Float32),
165177
],
166178
source=source,
167179
ttl=timedelta(hours=2),

sdk/python/tests/integration/offline_store/test_feature_logging.py

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,15 @@ def retrieve():
106106
)
107107

108108
persisted_logs = persisted_logs[expected_columns]
109+
109110
logs_df = logs_df[expected_columns]
111+
112+
# Convert timezone-aware datetime values to naive datetime values
113+
logs_df[LOG_TIMESTAMP_FIELD] = logs_df[LOG_TIMESTAMP_FIELD].dt.tz_localize(None)
114+
persisted_logs[LOG_TIMESTAMP_FIELD] = persisted_logs[
115+
LOG_TIMESTAMP_FIELD
116+
].dt.tz_localize(None)
117+
110118
pd.testing.assert_frame_equal(
111119
logs_df.sort_values(REQUEST_ID_FIELD).reset_index(drop=True),
112120
persisted_logs.sort_values(REQUEST_ID_FIELD).reset_index(drop=True),

0 commit comments

Comments
 (0)