chore: Remove dynamodb infraobject (feast-dev#5442)

* remove dynamo infra object proto stuff

Signed-off-by: Rob Howley <[email protected]>

* remove refs in infra diff

Signed-off-by: Rob Howley <[email protected]>

* run ruff

Signed-off-by: Rob Howley <[email protected]>

* update proto imports and tests

Signed-off-by: Rob Howley <[email protected]>

---------

Signed-off-by: Rob Howley <[email protected]>
Co-authored-by: Rob Howley <[email protected]>

Author: robhowley

protos/feast/core/DynamoDBTable.proto

@@ -22,7 +22,6 @@ option java_outer_classname = "InfraObjectProto";
 option go_package = "github.com/feast-dev/feast/go/protos/feast/core";
 
 import "feast/core/DatastoreTable.proto";
-import "feast/core/DynamoDBTable.proto";
 import "feast/core/SqliteTable.proto";
 
 // Represents a set of infrastructure objects managed by Feast
@@ -38,7 +37,6 @@ message InfraObject {
 
     // The infrastructure object
     oneof infra_object {
-        DynamoDBTable dynamodb_table = 2;
         DatastoreTable datastore_table = 3;
         SqliteTable sqlite_table = 4;
         CustomInfra custom_infra = 100;

protos/feast/core/InfraObject.proto

@@ -4,22 +4,16 @@
 from feast.diff.property_diff import PropertyDiff, TransitionType
 from feast.infra.infra_object import (
     DATASTORE_INFRA_OBJECT_CLASS_TYPE,
-    DYNAMODB_INFRA_OBJECT_CLASS_TYPE,
     SQLITE_INFRA_OBJECT_CLASS_TYPE,
     InfraObject,
 )
 from feast.protos.feast.core.DatastoreTable_pb2 import (
     DatastoreTable as DatastoreTableProto,
 )
-from feast.protos.feast.core.DynamoDBTable_pb2 import (
-    DynamoDBTable as DynamoDBTableProto,
-)
 from feast.protos.feast.core.InfraObject_pb2 import Infra as InfraProto
 from feast.protos.feast.core.SqliteTable_pb2 import SqliteTable as SqliteTableProto
 
-InfraObjectProto = TypeVar(
-    "InfraObjectProto", DatastoreTableProto, DynamoDBTableProto, SqliteTableProto
-)
+InfraObjectProto = TypeVar("InfraObjectProto", DatastoreTableProto, SqliteTableProto)
 
 
 @dataclass
@@ -110,7 +104,6 @@ def diff_infra_protos(
 
     infra_object_class_types_to_str = {
         DATASTORE_INFRA_OBJECT_CLASS_TYPE: "datastore table",
-        DYNAMODB_INFRA_OBJECT_CLASS_TYPE: "dynamodb table",
         SQLITE_INFRA_OBJECT_CLASS_TYPE: "sqlite table",
     }
 

sdk/python/feast/diff/infra_diff.py

@@ -20,15 +20,11 @@
 from feast.protos.feast.core.DatastoreTable_pb2 import (
     DatastoreTable as DatastoreTableProto,
 )
-from feast.protos.feast.core.DynamoDBTable_pb2 import (
-    DynamoDBTable as DynamoDBTableProto,
-)
 from feast.protos.feast.core.InfraObject_pb2 import Infra as InfraProto
 from feast.protos.feast.core.InfraObject_pb2 import InfraObject as InfraObjectProto
 from feast.protos.feast.core.SqliteTable_pb2 import SqliteTable as SqliteTableProto
 
 DATASTORE_INFRA_OBJECT_CLASS_TYPE = "feast.infra.online_stores.datastore.DatastoreTable"
-DYNAMODB_INFRA_OBJECT_CLASS_TYPE = "feast.infra.online_stores.dynamodb.DynamoDBTable"
 SQLITE_INFRA_OBJECT_CLASS_TYPE = "feast.infra.online_stores.sqlite.SqliteTable"
 
 
@@ -91,8 +87,6 @@ def from_proto(infra_object_proto: Any) -> Any:
         """
         if isinstance(infra_object_proto, DatastoreTableProto):
             infra_object_class_type = DATASTORE_INFRA_OBJECT_CLASS_TYPE
-        elif isinstance(infra_object_proto, DynamoDBTableProto):
-            infra_object_class_type = DYNAMODB_INFRA_OBJECT_CLASS_TYPE
         elif isinstance(infra_object_proto, SqliteTableProto):
             infra_object_class_type = SQLITE_INFRA_OBJECT_CLASS_TYPE
         else:

sdk/python/feast/infra/infra_object.py

@@ -23,15 +23,10 @@
 from pydantic import StrictBool, StrictStr
 
 from feast import Entity, FeatureView, utils
-from feast.infra.infra_object import DYNAMODB_INFRA_OBJECT_CLASS_TYPE, InfraObject
 from feast.infra.online_stores.helpers import compute_entity_id
 from feast.infra.online_stores.online_store import OnlineStore
 from feast.infra.supported_async_methods import SupportedAsyncMethods
 from feast.infra.utils.aws_utils import dynamo_write_items_async
-from feast.protos.feast.core.DynamoDBTable_pb2 import (
-    DynamoDBTable as DynamoDBTableProto,
-)
-from feast.protos.feast.core.InfraObject_pb2 import InfraObject as InfraObjectProto
 from feast.protos.feast.types.EntityKey_pb2 import EntityKey as EntityKeyProto
 from feast.protos.feast.types.Value_pb2 import Value as ValueProto
 from feast.repo_config import FeastConfigBaseModel, RepoConfig
@@ -717,94 +712,6 @@ def _delete_table_idempotent(
             logger.warning(f"Trying to delete table that doesn't exist: {table_name}")
 
 
-class DynamoDBTable(InfraObject):
-    """
-    A DynamoDB table managed by Feast.
-
-    Attributes:
-        name: The name of the table.
-        region: The region of the table.
-        endpoint_url: Local DynamoDB Endpoint Url.
-        _dynamodb_client: Boto3 DynamoDB client.
-        _dynamodb_resource: Boto3 DynamoDB resource.
-    """
-
-    region: str
-    endpoint_url = None
-    _dynamodb_client = None
-    _dynamodb_resource = None
-
-    def __init__(self, name: str, region: str, endpoint_url: Optional[str] = None):
-        super().__init__(name)
-        self.region = region
-        self.endpoint_url = endpoint_url
-
-    def to_infra_object_proto(self) -> InfraObjectProto:
-        dynamodb_table_proto = self.to_proto()
-        return InfraObjectProto(
-            infra_object_class_type=DYNAMODB_INFRA_OBJECT_CLASS_TYPE,
-            dynamodb_table=dynamodb_table_proto,
-        )
-
-    def to_proto(self) -> Any:
-        dynamodb_table_proto = DynamoDBTableProto()
-        dynamodb_table_proto.name = self.name
-        dynamodb_table_proto.region = self.region
-        return dynamodb_table_proto
-
-    @staticmethod
-    def from_infra_object_proto(infra_object_proto: InfraObjectProto) -> Any:
-        return DynamoDBTable(
-            name=infra_object_proto.dynamodb_table.name,
-            region=infra_object_proto.dynamodb_table.region,
-        )
-
-    @staticmethod
-    def from_proto(dynamodb_table_proto: DynamoDBTableProto) -> Any:
-        return DynamoDBTable(
-            name=dynamodb_table_proto.name,
-            region=dynamodb_table_proto.region,
-        )
-
-    def update(self):
-        dynamodb_client = self._get_dynamodb_client(self.region, self.endpoint_url)
-        dynamodb_resource = self._get_dynamodb_resource(self.region, self.endpoint_url)
-
-        try:
-            dynamodb_resource.create_table(
-                TableName=f"{self.name}",
-                KeySchema=[{"AttributeName": "entity_id", "KeyType": "HASH"}],
-                AttributeDefinitions=[
-                    {"AttributeName": "entity_id", "AttributeType": "S"}
-                ],
-                BillingMode="PAY_PER_REQUEST",
-            )
-        except ClientError as ce:
-            # If the table creation fails with ResourceInUseException,
-            # it means the table already exists or is being created.
-            # Otherwise, re-raise the exception
-            if ce.response["Error"]["Code"] != "ResourceInUseException":
-                raise
-
-        dynamodb_client.get_waiter("table_exists").wait(TableName=f"{self.name}")
-
-    def teardown(self):
-        dynamodb_resource = self._get_dynamodb_resource(self.region, self.endpoint_url)
-        _delete_table_idempotent(dynamodb_resource, self.name)
-
-    def _get_dynamodb_client(self, region: str, endpoint_url: Optional[str] = None):
-        if self._dynamodb_client is None:
-            self._dynamodb_client = _initialize_dynamodb_client(region, endpoint_url)
-        return self._dynamodb_client
-
-    def _get_dynamodb_resource(self, region: str, endpoint_url: Optional[str] = None):
-        if self._dynamodb_resource is None:
-            self._dynamodb_resource = _initialize_dynamodb_resource(
-                region, endpoint_url
-            )
-        return self._dynamodb_resource
-
-
 def _to_resource_write_item(config, entity_key, features, timestamp):
     entity_id = compute_entity_id(
         entity_key,

sdk/python/feast/infra/online_stores/dynamodb.py

@@ -19,7 +19,6 @@ isort:skip_file
 import builtins
 import collections.abc
 import feast.core.DatastoreTable_pb2
-import feast.core.DynamoDBTable_pb2
 import feast.core.SqliteTable_pb2
 import google.protobuf.descriptor
 import google.protobuf.internal.containers
@@ -71,15 +70,12 @@ class InfraObject(google.protobuf.message.Message):
         def ClearField(self, field_name: typing_extensions.Literal["field", b"field"]) -> None: ...
 
     INFRA_OBJECT_CLASS_TYPE_FIELD_NUMBER: builtins.int
-    DYNAMODB_TABLE_FIELD_NUMBER: builtins.int
     DATASTORE_TABLE_FIELD_NUMBER: builtins.int
     SQLITE_TABLE_FIELD_NUMBER: builtins.int
     CUSTOM_INFRA_FIELD_NUMBER: builtins.int
     infra_object_class_type: builtins.str
     """Represents the Python class for the infrastructure object"""
     @property
-    def dynamodb_table(self) -> feast.core.DynamoDBTable_pb2.DynamoDBTable: ...
-    @property
     def datastore_table(self) -> feast.core.DatastoreTable_pb2.DatastoreTable: ...
     @property
     def sqlite_table(self) -> feast.core.SqliteTable_pb2.SqliteTable: ...
@@ -89,13 +85,12 @@ class InfraObject(google.protobuf.message.Message):
         self,
         *,
         infra_object_class_type: builtins.str = ...,
-        dynamodb_table: feast.core.DynamoDBTable_pb2.DynamoDBTable | None = ...,
         datastore_table: feast.core.DatastoreTable_pb2.DatastoreTable | None = ...,
         sqlite_table: feast.core.SqliteTable_pb2.SqliteTable | None = ...,
         custom_infra: global___InfraObject.CustomInfra | None = ...,
     ) -> None: ...
-    def HasField(self, field_name: typing_extensions.Literal["custom_infra", b"custom_infra", "datastore_table", b"datastore_table", "dynamodb_table", b"dynamodb_table", "infra_object", b"infra_object", "sqlite_table", b"sqlite_table"]) -> builtins.bool: ...
-    def ClearField(self, field_name: typing_extensions.Literal["custom_infra", b"custom_infra", "datastore_table", b"datastore_table", "dynamodb_table", b"dynamodb_table", "infra_object", b"infra_object", "infra_object_class_type", b"infra_object_class_type", "sqlite_table", b"sqlite_table"]) -> None: ...
-    def WhichOneof(self, oneof_group: typing_extensions.Literal["infra_object", b"infra_object"]) -> typing_extensions.Literal["dynamodb_table", "datastore_table", "sqlite_table", "custom_infra"] | None: ...
+    def HasField(self, field_name: typing_extensions.Literal["custom_infra", b"custom_infra", "datastore_table", b"datastore_table", "infra_object", b"infra_object", "sqlite_table", b"sqlite_table"]) -> builtins.bool: ...
+    def ClearField(self, field_name: typing_extensions.Literal["custom_infra", b"custom_infra", "datastore_table", b"datastore_table", "infra_object", b"infra_object", "infra_object_class_type", b"infra_object_class_type", "sqlite_table", b"sqlite_table"]) -> None: ...
+    def WhichOneof(self, oneof_group: typing_extensions.Literal["infra_object", b"infra_object"]) -> typing_extensions.Literal["datastore_table", "sqlite_table", "custom_infra"] | None: ...
 
 global___InfraObject = InfraObject