applying changes from Chris' review

Author: tclose

pydra/engine/tests/conftest.py

@@ -1,6 +1,5 @@
 import pytest
 
-# from pydra import set_input_validator
 
 try:
     import importlib_resources

pydra/engine/tests/test_helpers.py

@@ -178,7 +178,7 @@ def test_load_and_run(tmpdir):
     """testing load_and_run for pickled task"""
     task_pkl = Path(tmpdir.join("task_main.pkl"))
 
-    task = multiply(name="mult").split("x", x=[1, 2], y=10)
+    task = multiply(name="mult", y=10).split(x=[1, 2])
     task.state.prepare_states(inputs=task.inputs)
     task.state.prepare_inputs()
     with task_pkl.open("wb") as fp:

pydra/engine/tests/test_helpers_file.py

@@ -49,6 +49,7 @@ def test_ensure_list(filename, expected):
 
 
 def test_copy_nested_files_copy(tmp_path: Path):
+    # Test copying files from within nested data structures
     src_dir = tmp_path / "src"
 
     src_dir.mkdir()

pydra/engine/tests/test_shelltask.py

@@ -1270,9 +1270,8 @@ def test_shell_cmd_inputspec_9a(tmp_path, plugin, results_function):
     the change: input file has directory with a dot
     """
     cmd = "cp"
-    ddir = tmp_path / "data.inp"
-    ddir.mkdir()
-    file = ddir / ("file.txt")
+    file = tmp_path / "data.inp" / "file.txt"
+    file.parent.mkdir()
     file.write_text("content\n")
 
     my_input_spec = SpecInfo(

pydra/engine/tests/test_shelltask_inputspec.py

@@ -1941,7 +1941,7 @@ def test_shell_cmd_inputs_template_1_st():
 
 
 # TODO: after deciding how we use requires/templates
-def test_shell_cmd_inputs_di(
+def test_shell_cmd_inputs_denoise_image(
     tmp_path,
 ):
     """example from #279"""