Skip to content

Commit fdebdb3

Browse files
oreflowTim Malmström
andauthored
Fixing go-lint issue to not use underscores in variable names (bazelbuild#1362)
Co-authored-by: Tim Malmström <[email protected]>
1 parent 5d14477 commit fdebdb3

File tree

1 file changed

+17
-17
lines changed

1 file changed

+17
-17
lines changed

edit/buildozer_test.go

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -633,18 +633,18 @@ func TestCmdDictAddSet_missingColon(t *testing.T) {
633633

634634
func TestCmdDictOperations(t *testing.T) {
635635
tests := []struct {
636-
name string
637-
dict_add_args []string
638-
dict_set_args []string
639-
dict_remove_args []string
640-
input string
641-
want string
636+
name string
637+
dictAddArgs []string
638+
dictSetArgs []string
639+
dictRemoveArgs []string
640+
input string
641+
want string
642642
}{
643643
{
644-
name: "dict_add_set_remove",
645-
dict_add_args: []string{"dict_attr", `added_entry:new_value`},
646-
dict_set_args: []string{"dict_attr", `entry_to_change:updated_value`},
647-
dict_remove_args: []string{"dict_attr", `entry_to_remove`},
644+
name: "dict_add_set_remove",
645+
dictAddArgs: []string{"dict_attr", `added_entry:new_value`},
646+
dictSetArgs: []string{"dict_attr", `entry_to_change:updated_value`},
647+
dictRemoveArgs: []string{"dict_attr", `entry_to_remove`},
648648
input: strings.Join([]string{
649649
`rule(`,
650650
` name = "rule_name",`,
@@ -666,10 +666,10 @@ func TestCmdDictOperations(t *testing.T) {
666666
}, "\n"),
667667
},
668668
{
669-
name: "dict_add_set_remove_with_escaped_colon",
670-
dict_add_args: []string{"dict_attr", `added\:entry:new:value`},
671-
dict_set_args: []string{"dict_attr", `entry\:to_change:updated\:value`},
672-
dict_remove_args: []string{"dict_attr", `entry\:to_remove`},
669+
name: "dict_add_set_remove_with_escaped_colon",
670+
dictAddArgs: []string{"dict_attr", `added\:entry:new:value`},
671+
dictSetArgs: []string{"dict_attr", `entry\:to_change:updated\:value`},
672+
dictRemoveArgs: []string{"dict_attr", `entry\:to_remove`},
673673
input: strings.Join([]string{
674674
`rule(`,
675675
` name = "rule_name",`,
@@ -698,17 +698,17 @@ func TestCmdDictOperations(t *testing.T) {
698698
t.Fatalf("build.Parse returned err: %s", err)
699699
}
700700
rule := file.RuleNamed("rule_name")
701-
file, err = cmdDictAdd(NewOpts(), CmdEnvironment{File: file, Rule: rule, Args: tc.dict_add_args})
701+
file, err = cmdDictAdd(NewOpts(), CmdEnvironment{File: file, Rule: rule, Args: tc.dictAddArgs})
702702
if err != nil {
703703
t.Fatalf("cmdDictAdd returned err: %s", err)
704704
}
705705

706-
file, err = cmdDictSet(NewOpts(), CmdEnvironment{File: file, Rule: rule, Args: tc.dict_set_args})
706+
file, err = cmdDictSet(NewOpts(), CmdEnvironment{File: file, Rule: rule, Args: tc.dictSetArgs})
707707
if err != nil {
708708
t.Fatalf("cmdDictSet returned err: %s", err)
709709
}
710710

711-
file, err = cmdDictRemove(NewOpts(), CmdEnvironment{File: file, Rule: rule, Args: tc.dict_remove_args})
711+
file, err = cmdDictRemove(NewOpts(), CmdEnvironment{File: file, Rule: rule, Args: tc.dictRemoveArgs})
712712
if err != nil {
713713
t.Fatalf("cmdDictRemove returned err: %s", err)
714714
}

0 commit comments

Comments
 (0)